From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH 2/3 v6] cpufreq: mediatek: Add MT8173 cpufreq driver
Date: Tue, 18 Aug 2015 15:54:28 +0530 [thread overview]
Message-ID: <20150818102428.GD31148@linux> (raw)
In-Reply-To: <18468574.WHJNqYO5N4@amdc1976>
On 18-08-15, 12:09, Bartlomiej Zolnierkiewicz wrote:
> > + pdev = platform_device_register_simple("mt8173-cpufreq", -1, NULL, 0);
>
> This is not very friendly for multiplatform support
> (mt8173_cpufreq_driver_init() can be called on other platforms,
> i.e. Samsung Exynos7 one if ARCH_EXYNOS7 is also enabled in
> the kernel config).
>
> Why can't it be fixed with checking Device Tree with
> of_machine_is_compatible("mediatek,mt8173")
> (assuming that it can be used on arm64 like on arm32)?
Because I asked him to remove that in v5 :( as I somehow had in mind
that this wouldn't even compile for other platforms.
@Pi-cheng: Please send v7 only for this patch and add the DT platform
check you were doing earlier. Sorry.
--
viresh
next prev parent reply other threads:[~2015-08-18 10:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 9:24 [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Pi-Cheng Chen
2015-08-17 9:24 ` [RESEND PATCH 1/3 v6] dt-bindings: mediatek: Add MT8173 CPU DVFS clock bindings Pi-Cheng Chen
2015-08-17 9:24 ` [RESEND PATCH 2/3 v6] cpufreq: mediatek: Add MT8173 cpufreq driver Pi-Cheng Chen
2015-08-18 10:09 ` Bartlomiej Zolnierkiewicz
2015-08-18 10:24 ` Viresh Kumar [this message]
2015-08-19 2:05 ` [PATCH v7 2/3] " Pi-Cheng Chen
2015-08-19 5:41 ` Viresh Kumar
2015-08-17 9:24 ` [RESEND PATCH 3/3 v6] arm64: dts: mt8173: mt8173-evb: Add mt8173 cpufreq driver support Pi-Cheng Chen
2015-08-25 2:10 ` [RESEND PATCH 0/3 v6] Add Mediatek MT8173 cpufreq driver Pi-Cheng Chen
2015-08-25 23:01 ` Rafael J. Wysocki
2015-08-26 1:25 ` Pi-Cheng Chen
2015-08-26 2:16 ` Viresh Kumar
2015-08-26 6:53 ` Pi-Cheng Chen
2015-08-28 14:06 ` Rafael J. Wysocki
2015-09-02 6:45 ` Daniel Kurtz
2015-09-02 17:23 ` Matthias Brugger
2016-04-21 10:26 ` Matthias Brugger
2016-04-21 10:58 ` Matthias Brugger
2016-04-21 11:37 ` Eddie Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818102428.GD31148@linux \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox