* [PATCH] ASoC: Samsung: Remove redundant arndale_audio_remove
@ 2015-08-20 16:41 Vaishali Thakkar
2015-08-21 0:48 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Vaishali Thakkar @ 2015-08-20 16:41 UTC (permalink / raw)
To: linux-arm-kernel
There is no use of snd_soc_unregister_card in remove function
as devm_snd_soc_register_card in probe function automatically
handles it. So, remove use of snd_soc_unregister_card and with
this change remove arndale_audio_remove as it is now redundant.
Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
---
sound/soc/samsung/arndale_rt5631.c | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/sound/soc/samsung/arndale_rt5631.c b/sound/soc/samsung/arndale_rt5631.c
index 8bf2e2c..9e371eb 100644
--- a/sound/soc/samsung/arndale_rt5631.c
+++ b/sound/soc/samsung/arndale_rt5631.c
@@ -116,15 +116,6 @@ static int arndale_audio_probe(struct platform_device *pdev)
return ret;
}
-static int arndale_audio_remove(struct platform_device *pdev)
-{
- struct snd_soc_card *card = platform_get_drvdata(pdev);
-
- snd_soc_unregister_card(card);
-
- return 0;
-}
-
static const struct of_device_id samsung_arndale_rt5631_of_match[] __maybe_unused = {
{ .compatible = "samsung,arndale-rt5631", },
{ .compatible = "samsung,arndale-alc5631", },
@@ -139,7 +130,6 @@ static struct platform_driver arndale_audio_driver = {
.of_match_table = of_match_ptr(samsung_arndale_rt5631_of_match),
},
.probe = arndale_audio_probe,
- .remove = arndale_audio_remove,
};
module_platform_driver(arndale_audio_driver);
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ASoC: Samsung: Remove redundant arndale_audio_remove
2015-08-20 16:41 [PATCH] ASoC: Samsung: Remove redundant arndale_audio_remove Vaishali Thakkar
@ 2015-08-21 0:48 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-21 0:48 UTC (permalink / raw)
To: linux-arm-kernel
On 21.08.2015 01:41, Vaishali Thakkar wrote:
> There is no use of snd_soc_unregister_card in remove function
> as devm_snd_soc_register_card in probe function automatically
> handles it. So, remove use of snd_soc_unregister_card and with
> this change remove arndale_audio_remove as it is now redundant.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>z
> ---
> sound/soc/samsung/arndale_rt5631.c | 10 ----------
> 1 file changed, 10 deletions(-)
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-21 0:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-20 16:41 [PATCH] ASoC: Samsung: Remove redundant arndale_audio_remove Vaishali Thakkar
2015-08-21 0:48 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).