public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: dmitry.torokhov@gmail.com (Dmitry Torokhov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/5] input: touchscreen: add imx6ul_tsc driver support
Date: Sat, 5 Sep 2015 11:53:08 -0700	[thread overview]
Message-ID: <20150905185308.GC18006@dtor-ws> (raw)
In-Reply-To: <1440752976-9094-2-git-send-email-haibo.chen@freescale.com>

On Fri, Aug 28, 2015 at 05:09:32PM +0800, Haibo Chen wrote:
> Freescale i.MX6UL contains a internal touchscreen controller,
> this patch add a driver to support this controller.
> 
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>

Merged #1 and #2 and applied, thank you.

Also:

> +		/*
> +		 * Delay some time(max 2ms), wait the pre-charge done.
> +		 * After the pre-change mode, TSC go into detect mode.
> +		 * And in detect mode, we can get the xnur gpio value.
> +		 * If xnur is high, this means the touch screen still
> +		 * be touched. If xnur is low, this means finger leave
> +		 * the touch screen.
> +		 */
> +		timeout = jiffies + HZ/500;

I do not think that would quite work with HZ < 500. I changed this to

		timeout = jiffies + msecs_to_jiffies(2);

and also moved this block into a separate function.

Thanks.

-- 
Dmitry

  parent reply	other threads:[~2015-09-05 18:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-28  9:09 [PATCH v3 0/5] Add imx6ul touch screen controller support Haibo Chen
2015-08-28  9:09 ` [PATCH v3 1/5] input: touchscreen: add imx6ul_tsc driver support Haibo Chen
2015-08-28 11:19   ` Lothar Waßmann
2015-09-05 18:53   ` Dmitry Torokhov [this message]
2015-08-28  9:09 ` [PATCH v3 2/5] Documentation: Detail permitted DT properties for the imx6ul_tsc Haibo Chen
2015-08-28  9:09 ` [PATCH v3 3/5] ARM: imx_v6_v7_defconfig: enable imx6ul_tsc Haibo Chen
2015-09-07  0:27   ` Shawn Guo
2015-08-28  9:09 ` [PATCH v3 4/5] ARM: dts: imx6ul.dtsi: add TSC support Haibo Chen
2015-08-28  9:09 ` [PATCH v3 5/5] ARM: dts: imx6ul-14x14-evk.dts: add tsc support Haibo Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150905185308.GC18006@dtor-ws \
    --to=dmitry.torokhov@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox