linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header
@ 2015-08-19 13:19 Lucas Stach
  2015-08-19 13:19 ` [PATCH 2/2] ARM: imx53: qsrb: fix PMIC interrupt level Lucas Stach
  2015-09-06 11:55 ` [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header Shawn Guo
  0 siblings, 2 replies; 3+ messages in thread
From: Lucas Stach @ 2015-08-19 13:19 UTC (permalink / raw)
  To: linux-arm-kernel

Allows to use the more meaningful IRQ flag defines instead of
the raw values.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/boot/dts/imx53.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index c3e3ca9362fb..cd170376eaca 100644
--- a/arch/arm/boot/dts/imx53.dtsi
+++ b/arch/arm/boot/dts/imx53.dtsi
@@ -15,6 +15,7 @@
 #include <dt-bindings/clock/imx5-clock.h>
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/interrupt-controller/irq.h>
 
 / {
 	aliases {
-- 
2.4.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 2/2] ARM: imx53: qsrb: fix PMIC interrupt level
  2015-08-19 13:19 [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header Lucas Stach
@ 2015-08-19 13:19 ` Lucas Stach
  2015-09-06 11:55 ` [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Lucas Stach @ 2015-08-19 13:19 UTC (permalink / raw)
  To: linux-arm-kernel

The MC34708 PMIC interrupt level is active high, but was set to
active low in the devicetree, probably as a result of a copy and
paste error from the QSB board.

This caused IRQ storms and led to the kernel disabling the PMIC
interrupt.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 arch/arm/boot/dts/imx53-qsrb.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx53-qsrb.dts b/arch/arm/boot/dts/imx53-qsrb.dts
index 82d623d05915..bbb3f4b7a7fe 100644
--- a/arch/arm/boot/dts/imx53-qsrb.dts
+++ b/arch/arm/boot/dts/imx53-qsrb.dts
@@ -48,7 +48,7 @@
 		pinctrl-0 = <&pinctrl_pmic>;
 		reg = <0x08>;
 		interrupt-parent = <&gpio5>;
-		interrupts = <23 0x8>;
+		interrupts = <23 IRQ_TYPE_LEVEL_HIGH>;
 		regulators {
 			sw1_reg: sw1a {
 				regulator-name = "SW1";
-- 
2.4.6

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header
  2015-08-19 13:19 [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header Lucas Stach
  2015-08-19 13:19 ` [PATCH 2/2] ARM: imx53: qsrb: fix PMIC interrupt level Lucas Stach
@ 2015-09-06 11:55 ` Shawn Guo
  1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2015-09-06 11:55 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Aug 19, 2015 at 03:19:46PM +0200, Lucas Stach wrote:
> Allows to use the more meaningful IRQ flag defines instead of
> the raw values.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Applied both, thanks.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-09-06 11:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-19 13:19 [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header Lucas Stach
2015-08-19 13:19 ` [PATCH 2/2] ARM: imx53: qsrb: fix PMIC interrupt level Lucas Stach
2015-09-06 11:55 ` [PATCH 1/2] ARM: imx53: include IRQ dt-bindings header Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).