From: maitysanchayan@gmail.com (maitysanchayan at gmail.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
Date: Mon, 7 Sep 2015 14:19:11 +0530 [thread overview]
Message-ID: <20150907084911.GA6877@Sanchayan-Arch.toradex.int> (raw)
In-Reply-To: <20150906043232.GD30746@tiger>
Hi Shawn,
On 15-09-06 12:32:32, Shawn Guo wrote:
> On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> > Add iio_hwmon node to expose the temperature channel on Vybrid
> > as hardware monitor device using the iio_hwmon driver.
> >
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> > index 39173bb..0993d66 100644
> > --- a/arch/arm/boot/dts/vfxxx.dtsi
> > +++ b/arch/arm/boot/dts/vfxxx.dtsi
> > @@ -597,5 +597,10 @@
> > status = "disabled";
> > };
> > };
> > +
> > + iio_hwmon {
>
> Hyphen rather than underscore should be used in node name.
As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi.
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246
So should this be changed?
Thanks.
- Sanchayan.
>
> Shawn
>
> > + compatible = "iio-hwmon";
> > + io-channels = <&adc0 16>;
> > + };
> > };
> > };
> > --
> > 2.5.0
> >
next prev parent reply other threads:[~2015-09-07 8:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-06 15:58 [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Sanchayan Maity
2015-08-21 12:11 ` maitysanchayan at gmail.com
2015-09-06 4:32 ` Shawn Guo
2015-09-07 8:49 ` maitysanchayan at gmail.com [this message]
2015-09-17 1:04 ` Shawn Guo
2015-09-06 4:35 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150907084911.GA6877@Sanchayan-Arch.toradex.int \
--to=maitysanchayan@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).