linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] ARM: dts: imx7d: Add USB support
@ 2015-09-08  1:57 Fabio Estevam
  2015-09-08  1:57 ` [PATCH v2 2/2] ARM: dts: imx7d-sdb: " Fabio Estevam
                   ` (3 more replies)
  0 siblings, 4 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-09-08  1:57 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@freescale.com>

Add USB OTG and Host support.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- Remove underscore from node name as suggested by Shawn

 arch/arm/boot/dts/imx7d.dtsi | 71 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 15c2193..90eb9f4 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -746,6 +746,77 @@
 				status = "disabled";
 			};
 
+			usbotg1: usb at 30b10000 {
+				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
+				reg = <0x30b10000 0x200>;
+				interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX7D_USB_CTRL_CLK>;
+				fsl,usbphy = <&usbphynop1>;
+				fsl,usbmisc = <&usbmisc1 0>;
+				phy-clkgate-delay-us = <400>;
+				status = "disabled";
+			};
+
+			usbotg2: usb at 30b20000 {
+				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
+				reg = <0x30b20000 0x200>;
+				interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX7D_USB_CTRL_CLK>;
+				fsl,usbphy = <&usbphynop2>;
+				fsl,usbmisc = <&usbmisc2 0>;
+				phy-clkgate-delay-us = <400>;
+				status = "disabled";
+			};
+
+			usbh: usb at 30b30000 {
+				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
+				reg = <0x30b30000 0x200>;
+				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
+				clocks = <&clks IMX7D_USB_CTRL_CLK>;
+				fsl,usbphy = <&usbphynop3>;
+				fsl,usbmisc = <&usbmisc3 0>;
+				phy_type = "hsic";
+				dr_mode = "host";
+				phy-clkgate-delay-us = <400>;
+				status = "disabled";
+			};
+
+			usbmisc1: usbmisc at 30b10200 {
+				#index-cells = <1>;
+				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
+				reg = <0x30b10200 0x200>;
+			};
+
+			usbmisc2: usbmisc at 30b20200 {
+				#index-cells = <1>;
+				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
+				reg = <0x30b20200 0x200>;
+			};
+
+			usbmisc3: usbmisc at 30b30200 {
+				#index-cells = <1>;
+				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
+				reg = <0x30b30200 0x200>;
+			};
+
+			usbphynop1: usbphynop1 {
+				compatible = "usb-nop-xceiv";
+				clocks = <&clks IMX7D_USB_PHY1_CLK>;
+				clock-names = "main_clk";
+			};
+
+			usbphynop2: usbphynop2 {
+				compatible = "usb-nop-xceiv";
+				clocks = <&clks IMX7D_USB_PHY2_CLK>;
+				clock-names = "main_clk";
+			};
+
+			usbphynop3: usbphynop3 {
+				compatible = "usb-nop-xceiv";
+				clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
+				clock-names = "main_clk";
+			};
+
 			usdhc1: usdhc at 30b40000 {
 				compatible = "fsl,imx7d-usdhc", "fsl,imx6sl-usdhc";
 				reg = <0x30b40000 0x10000>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 2/2] ARM: dts: imx7d-sdb: Add USB support
  2015-09-08  1:57 [PATCH v2 1/2] ARM: dts: imx7d: Add USB support Fabio Estevam
@ 2015-09-08  1:57 ` Fabio Estevam
  2015-09-08  5:54   ` Peter Chen
  2015-09-08  5:52 ` [PATCH v2 1/2] ARM: dts: imx7d: " Peter Chen
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2015-09-08  1:57 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@freescale.com>

Add support for USBOTG1 and USBOTG2.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
Changes since v1:
- None

 arch/arm/boot/dts/imx7d-sdb.dts | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
index fdd1d7c..3c6cf52 100644
--- a/arch/arm/boot/dts/imx7d-sdb.dts
+++ b/arch/arm/boot/dts/imx7d-sdb.dts
@@ -231,6 +231,17 @@
 	status = "okay";
 };
 
+&usbotg1 {
+	vbus-supply = <&reg_usb_otg1_vbus>;
+	status = "okay";
+};
+
+&usbotg2 {
+	vbus-supply = <&reg_usb_otg2_vbus>;
+	dr_mode = "host";
+	status = "okay";
+};
+
 &usdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usdhc1>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH v2 1/2] ARM: dts: imx7d: Add USB support
  2015-09-08  1:57 [PATCH v2 1/2] ARM: dts: imx7d: Add USB support Fabio Estevam
  2015-09-08  1:57 ` [PATCH v2 2/2] ARM: dts: imx7d-sdb: " Fabio Estevam
@ 2015-09-08  5:52 ` Peter Chen
  2015-09-09  1:21   ` Fabio Estevam
  2015-09-09  2:26 ` Peter Chen
  2015-09-23  0:41 ` Shawn Guo
  3 siblings, 1 reply; 8+ messages in thread
From: Peter Chen @ 2015-09-08  5:52 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 07, 2015 at 10:57:11PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Add USB OTG and Host support.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Remove underscore from node name as suggested by Shawn
> 
>  arch/arm/boot/dts/imx7d.dtsi | 71 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 71 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 15c2193..90eb9f4 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -746,6 +746,77 @@
>  				status = "disabled";
>  			};
>  
> +			usbotg1: usb at 30b10000 {
> +				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> +				reg = <0x30b10000 0x200>;
> +				interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_USB_CTRL_CLK>;
> +				fsl,usbphy = <&usbphynop1>;
> +				fsl,usbmisc = <&usbmisc1 0>;
> +				phy-clkgate-delay-us = <400>;

You may add above property description at related binding doc

Peter

> +				status = "disabled";
> +			};
> +
> +			usbotg2: usb at 30b20000 {
> +				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> +				reg = <0x30b20000 0x200>;
> +				interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_USB_CTRL_CLK>;
> +				fsl,usbphy = <&usbphynop2>;
> +				fsl,usbmisc = <&usbmisc2 0>;
> +				phy-clkgate-delay-us = <400>;
> +				status = "disabled";
> +			};
> +
> +			usbh: usb at 30b30000 {
> +				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> +				reg = <0x30b30000 0x200>;
> +				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_USB_CTRL_CLK>;
> +				fsl,usbphy = <&usbphynop3>;
> +				fsl,usbmisc = <&usbmisc3 0>;
> +				phy_type = "hsic";
> +				dr_mode = "host";
> +				phy-clkgate-delay-us = <400>;
> +				status = "disabled";
> +			};
> +
> +			usbmisc1: usbmisc at 30b10200 {
> +				#index-cells = <1>;
> +				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
> +				reg = <0x30b10200 0x200>;
> +			};
> +
> +			usbmisc2: usbmisc at 30b20200 {
> +				#index-cells = <1>;
> +				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
> +				reg = <0x30b20200 0x200>;
> +			};
> +
> +			usbmisc3: usbmisc at 30b30200 {
> +				#index-cells = <1>;
> +				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
> +				reg = <0x30b30200 0x200>;
> +			};
> +
> +			usbphynop1: usbphynop1 {
> +				compatible = "usb-nop-xceiv";
> +				clocks = <&clks IMX7D_USB_PHY1_CLK>;
> +				clock-names = "main_clk";
> +			};
> +
> +			usbphynop2: usbphynop2 {
> +				compatible = "usb-nop-xceiv";
> +				clocks = <&clks IMX7D_USB_PHY2_CLK>;
> +				clock-names = "main_clk";
> +			};
> +
> +			usbphynop3: usbphynop3 {
> +				compatible = "usb-nop-xceiv";
> +				clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
> +				clock-names = "main_clk";
> +			};
> +
>  			usdhc1: usdhc at 30b40000 {
>  				compatible = "fsl,imx7d-usdhc", "fsl,imx6sl-usdhc";
>  				reg = <0x30b40000 0x10000>;
> -- 
> 1.9.1
> 

-- 

Best Regards,
Peter Chen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 2/2] ARM: dts: imx7d-sdb: Add USB support
  2015-09-08  1:57 ` [PATCH v2 2/2] ARM: dts: imx7d-sdb: " Fabio Estevam
@ 2015-09-08  5:54   ` Peter Chen
  0 siblings, 0 replies; 8+ messages in thread
From: Peter Chen @ 2015-09-08  5:54 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 07, 2015 at 10:57:12PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Add support for USBOTG1 and USBOTG2.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - None
> 
>  arch/arm/boot/dts/imx7d-sdb.dts | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
> index fdd1d7c..3c6cf52 100644
> --- a/arch/arm/boot/dts/imx7d-sdb.dts
> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
> @@ -231,6 +231,17 @@
>  	status = "okay";
>  };
>  
> +&usbotg1 {
> +	vbus-supply = <&reg_usb_otg1_vbus>;
> +	status = "okay";
> +};
> +
> +&usbotg2 {
> +	vbus-supply = <&reg_usb_otg2_vbus>;
> +	dr_mode = "host";
> +	status = "okay";
> +};
> +
>  &usdhc1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usdhc1>;
> -- 
> 1.9.1
> 

Acked-by: Peter Chen <peter.chen@freescale.com>

-- 

Best Regards,
Peter Chen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/2] ARM: dts: imx7d: Add USB support
  2015-09-08  5:52 ` [PATCH v2 1/2] ARM: dts: imx7d: " Peter Chen
@ 2015-09-09  1:21   ` Fabio Estevam
  0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-09-09  1:21 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Peter,

On Tue, Sep 8, 2015 at 2:52 AM, Peter Chen <peter.chen@freescale.com> wrote:

>> +                             phy-clkgate-delay-us = <400>;
>
> You may add above property description at related binding doc

Just sent patches adding 'phy-clkgate-delay-us' property in the usb
code and also into the doc binding.

Regards,

Fabio Estevam

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/2] ARM: dts: imx7d: Add USB support
  2015-09-08  1:57 [PATCH v2 1/2] ARM: dts: imx7d: Add USB support Fabio Estevam
  2015-09-08  1:57 ` [PATCH v2 2/2] ARM: dts: imx7d-sdb: " Fabio Estevam
  2015-09-08  5:52 ` [PATCH v2 1/2] ARM: dts: imx7d: " Peter Chen
@ 2015-09-09  2:26 ` Peter Chen
  2015-09-23  0:41 ` Shawn Guo
  3 siblings, 0 replies; 8+ messages in thread
From: Peter Chen @ 2015-09-09  2:26 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 07, 2015 at 10:57:11PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Add USB OTG and Host support.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> Changes since v1:
> - Remove underscore from node name as suggested by Shawn
> 
>  arch/arm/boot/dts/imx7d.dtsi | 71 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 71 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 15c2193..90eb9f4 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -746,6 +746,77 @@
>  				status = "disabled";
>  			};
>  
> +			usbotg1: usb at 30b10000 {
> +				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> +				reg = <0x30b10000 0x200>;
> +				interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_USB_CTRL_CLK>;
> +				fsl,usbphy = <&usbphynop1>;
> +				fsl,usbmisc = <&usbmisc1 0>;
> +				phy-clkgate-delay-us = <400>;
> +				status = "disabled";
> +			};
> +
> +			usbotg2: usb at 30b20000 {
> +				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> +				reg = <0x30b20000 0x200>;
> +				interrupts = <GIC_SPI 42 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_USB_CTRL_CLK>;
> +				fsl,usbphy = <&usbphynop2>;
> +				fsl,usbmisc = <&usbmisc2 0>;
> +				phy-clkgate-delay-us = <400>;
> +				status = "disabled";
> +			};
> +
> +			usbh: usb at 30b30000 {
> +				compatible = "fsl,imx7d-usb", "fsl,imx27-usb";
> +				reg = <0x30b30000 0x200>;
> +				interrupts = <GIC_SPI 40 IRQ_TYPE_LEVEL_HIGH>;
> +				clocks = <&clks IMX7D_USB_CTRL_CLK>;
> +				fsl,usbphy = <&usbphynop3>;
> +				fsl,usbmisc = <&usbmisc3 0>;
> +				phy_type = "hsic";
> +				dr_mode = "host";
> +				phy-clkgate-delay-us = <400>;
> +				status = "disabled";
> +			};
> +
> +			usbmisc1: usbmisc at 30b10200 {
> +				#index-cells = <1>;
> +				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
> +				reg = <0x30b10200 0x200>;
> +			};
> +
> +			usbmisc2: usbmisc at 30b20200 {
> +				#index-cells = <1>;
> +				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
> +				reg = <0x30b20200 0x200>;
> +			};
> +
> +			usbmisc3: usbmisc at 30b30200 {
> +				#index-cells = <1>;
> +				compatible = "fsl,imx7d-usbmisc", "fsl,imx6q-usbmisc";
> +				reg = <0x30b30200 0x200>;
> +			};
> +
> +			usbphynop1: usbphynop1 {
> +				compatible = "usb-nop-xceiv";
> +				clocks = <&clks IMX7D_USB_PHY1_CLK>;
> +				clock-names = "main_clk";
> +			};
> +
> +			usbphynop2: usbphynop2 {
> +				compatible = "usb-nop-xceiv";
> +				clocks = <&clks IMX7D_USB_PHY2_CLK>;
> +				clock-names = "main_clk";
> +			};
> +
> +			usbphynop3: usbphynop3 {
> +				compatible = "usb-nop-xceiv";
> +				clocks = <&clks IMX7D_USB_HSIC_ROOT_CLK>;
> +				clock-names = "main_clk";
> +			};
> +
>  			usdhc1: usdhc at 30b40000 {
>  				compatible = "fsl,imx7d-usdhc", "fsl,imx6sl-usdhc";
>  				reg = <0x30b40000 0x10000>;
> -- 
> 1.9.1
> 

Acked-by: Peter Chen <peter.chen@freescale.com>

-- 

Best Regards,
Peter Chen

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/2] ARM: dts: imx7d: Add USB support
  2015-09-08  1:57 [PATCH v2 1/2] ARM: dts: imx7d: Add USB support Fabio Estevam
                   ` (2 preceding siblings ...)
  2015-09-09  2:26 ` Peter Chen
@ 2015-09-23  0:41 ` Shawn Guo
  2015-09-23  2:44   ` Peter Chen
  3 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2015-09-23  0:41 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 07, 2015 at 10:57:11PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Add USB OTG and Host support.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied both, with assuming that property phy-clkgate-delay-us has been
accepted.

Shawn

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH v2 1/2] ARM: dts: imx7d: Add USB support
  2015-09-23  0:41 ` Shawn Guo
@ 2015-09-23  2:44   ` Peter Chen
  0 siblings, 0 replies; 8+ messages in thread
From: Peter Chen @ 2015-09-23  2:44 UTC (permalink / raw)
  To: linux-arm-kernel

On Tue, Sep 22, 2015 at 05:41:45PM -0700, Shawn Guo wrote:
> On Mon, Sep 07, 2015 at 10:57:11PM -0300, Fabio Estevam wrote:
> > From: Fabio Estevam <fabio.estevam@freescale.com>
> > 
> > Add USB OTG and Host support.
> > 
> > Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Applied both, with assuming that property phy-clkgate-delay-us has been
> accepted.
> 

Yes, I have accepted that.

-- 

Best Regards,
Peter Chen

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-09-23  2:44 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-08  1:57 [PATCH v2 1/2] ARM: dts: imx7d: Add USB support Fabio Estevam
2015-09-08  1:57 ` [PATCH v2 2/2] ARM: dts: imx7d-sdb: " Fabio Estevam
2015-09-08  5:54   ` Peter Chen
2015-09-08  5:52 ` [PATCH v2 1/2] ARM: dts: imx7d: " Peter Chen
2015-09-09  1:21   ` Fabio Estevam
2015-09-09  2:26 ` Peter Chen
2015-09-23  0:41 ` Shawn Guo
2015-09-23  2:44   ` Peter Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).