From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] Add eeprom to the Olimex series of boards
Date: Wed, 9 Sep 2015 16:05:59 +0200 [thread overview]
Message-ID: <20150909140559.GD9885@lukather> (raw)
In-Reply-To: <1441790715-11957-1-git-send-email-o.schinagl@ultimaker.com>
On Wed, Sep 09, 2015 at 11:25:10AM +0200, Olliver Schinagl wrote:
> Some of the olimex series of boards feature a permanently connected eeprom on
> i2c-1. This patch series adds them on all the boards that have them according
> to the spec-sheets.
>
> I explicitly added my personal --Tested-by to boards I actually tested.
Testing your changes is the strict minimum before testing your
patches. Just like running checkpatch on them, which you clearly
failed to do, otherwise you would have seen that this is not the right
syntax. Drop the tested-by, fix your SoB.
> There are two boards, that according to the sheets have them as well
> and physically inspecting the boards shows them clearly, I did not
> actually test them on those the boards that are missing the
> --Tested-by.
Then don't send those patches.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150909/b7a04104/attachment.sig>
next prev parent reply other threads:[~2015-09-09 14:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-09 9:25 [PATCH 0/5] Add eeprom to the Olimex series of boards Olliver Schinagl
2015-09-09 9:25 ` [PATCH 1/5] dts: sunxi: add eeprom to A10 OLinuXino Lime board Olliver Schinagl
2015-09-09 9:25 ` [PATCH 2/5] dts: sunxi: correct vendor prefix on OLinuXino a10s micro Olliver Schinagl
2015-09-09 9:25 ` [PATCH 3/5] dts: sunxi: add eeprom to A20 OLinuXino Lime board Olliver Schinagl
2015-09-09 9:25 ` [PATCH 4/5] dts: sunxi: add eeprom to A20 OLinuXino Lime2 board Olliver Schinagl
2015-09-09 9:25 ` [PATCH 5/5] dts: sunxi: add eeprom to A20 OLinuXino micro board Olliver Schinagl
2015-09-09 14:05 ` Maxime Ripard [this message]
2015-09-09 14:26 ` [PATCH 0/5] Add eeprom to the Olimex series of boards Olliver Schinagl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150909140559.GD9885@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).