linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: cpufreq: mediatek: allow modular build
Date: Fri, 11 Sep 2015 13:47:53 +0530	[thread overview]
Message-ID: <20150911081753.GK9650@linux> (raw)
In-Reply-To: <1768766.yu1lxjsjLL@wuerfel>

On 11-09-15, 10:15, Arnd Bergmann wrote:
> The newly merged cpufreq-mt8173 driver breaks the ARM allmodconfig
> build because of a dependency on the cpu-cooling infrastructure that
> may be built as a loadable module:
> 
> drivers/built-in.o: In function `mtk_cpufreq_ready':
> binder.c:(.text+0x324c8c): undefined reference to `of_cpufreq_cooling_register'
> drivers/built-in.o: In function `mtk_cpufreq_exit':
> binder.c:(.text+0x324ea0): undefined reference to `cpufreq_cooling_unregister'
> 
> This works around the issue by allowing this driver to be built
> as a module as well, and adding a dependency on THERMAL that prevents
> it from being built-in when the cpu-cooling driver is a module.
> 
> This is not perfect because there is still a case where THERMAL=m
> and CPU_COOLING=n that should allow us to have this driver built-in
> as well, but I decided to follow existing practice in other drivers
> here, and that case seems irrelevant in practice.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> I have not checked if someone else has already sent a patch for this,
> just ignore mine if the issue has been fixed already.

5269e7067cd6 ("cpufreq: Add ARM_MT8173_CPUFREQ dependency on THERMAL")

in Rafael's tree. Its a bit different, so have a look.
-- 
viresh

  reply	other threads:[~2015-09-11  8:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-11  8:15 cpufreq: mediatek: allow modular build Arnd Bergmann
2015-09-11  8:17 ` Viresh Kumar [this message]
2015-09-11  8:22   ` Arnd Bergmann
2015-09-11  8:25     ` Viresh Kumar
2015-09-11  8:36       ` Arnd Bergmann
2015-09-11  8:38         ` Viresh Kumar
2015-09-11  9:34           ` Russell King - ARM Linux
2015-09-11  9:40             ` Viresh Kumar
2015-09-11  9:58               ` Russell King - ARM Linux
2015-09-11 10:09                 ` Viresh Kumar
2015-09-11 10:13                   ` Russell King - ARM Linux
2015-09-11 10:19                     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150911081753.GK9650@linux \
    --to=viresh.kumar@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).