From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: rockchip: add critical clock for rk3368
Date: Mon, 14 Sep 2015 15:19:21 +0100 [thread overview]
Message-ID: <20150914141920.GF7002@leverpostej> (raw)
In-Reply-To: <5267432.TORlj1Iv40@diego>
On Sun, Sep 13, 2015 at 12:20:36PM +0100, Heiko St?bner wrote:
> Again a result of the gpio-clock-liberation the rk3368 needs the
> pclk_pd_pmu marked as critical, to boot successfully.
>
> Reported-by: Mark Rutland <mark.rutland@arm.com>
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
FWIW: Tested-by: Mark Rutland <mark.rutland@arm.com>
I'm surprised that we don't describe these as critical in the DT, given
that this isn't really an internal property of the clock controller, but
rather what happens to be attached to it. That ship appears to have
sailed, however.
Thanks,
Mark.
> ---
> should go on top of clk-fixes. Sorry only finding these piece
> by piece :-) .
>
> drivers/clk/rockchip/clk-rk3368.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/clk/rockchip/clk-rk3368.c b/drivers/clk/rockchip/clk-rk3368.c
> index 9c5d61e..7e6b783 100644
> --- a/drivers/clk/rockchip/clk-rk3368.c
> +++ b/drivers/clk/rockchip/clk-rk3368.c
> @@ -818,6 +818,10 @@ static struct rockchip_clk_branch rk3368_clk_branches[] __initdata = {
> GATE(0, "sclk_timer00", "xin24m", CLK_IGNORE_UNUSED, RK3368_CLKGATE_CON(24), 0, GFLAGS),
> };
>
> +static const char *const rk3368_critical_clocks[] __initconst = {
> + "pclk_pd_pmu",
> +};
> +
> static void __init rk3368_clk_init(struct device_node *np)
> {
> void __iomem *reg_base;
> @@ -862,6 +866,8 @@ static void __init rk3368_clk_init(struct device_node *np)
> RK3368_GRF_SOC_STATUS0);
> rockchip_clk_register_branches(rk3368_clk_branches,
> ARRAY_SIZE(rk3368_clk_branches));
> + rockchip_clk_protect_critical(rk3368_critical_clocks,
> + ARRAY_SIZE(rk3368_critical_clocks));
>
> rockchip_clk_register_armclk(ARMCLKB, "armclkb",
> mux_armclkb_p, ARRAY_SIZE(mux_armclkb_p),
> --
> 2.5.1
>
>
next prev parent reply other threads:[~2015-09-14 14:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-13 11:20 [PATCH] clk: rockchip: add critical clock for rk3368 Heiko Stübner
2015-09-14 14:19 ` Mark Rutland [this message]
2015-09-14 15:06 ` Heiko Stübner
2015-09-14 15:19 ` Mark Rutland
2015-09-14 15:24 ` Heiko Stübner
2015-09-14 19:49 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914141920.GF7002@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).