From: lorenzo.pieralisi@arm.com (Lorenzo Pieralisi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle
Date: Wed, 16 Sep 2015 15:47:38 +0100 [thread overview]
Message-ID: <20150916144738.GA23245@red-moon> (raw)
In-Reply-To: <1442413401-2955-1-git-send-email-jszhang@marvell.com>
On Wed, Sep 16, 2015 at 03:23:21PM +0100, Jisheng Zhang wrote:
> Currently, if cpuidle is disabled or not supported, powertop reports
> zero wakeups and zero events. This is due to the cpu_idle tracepoints
> are missing.
>
> This patch is to make cpu_idle tracepoints always available even if
> cpuidle is disabled or not supported.
>
> Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
Is there a reason why this code cannot be moved to the generic idle loop ?
Thanks,
Lorenzo
> ---
> arch/arm64/kernel/process.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> index 223b093..f75b540 100644
> --- a/arch/arm64/kernel/process.c
> +++ b/arch/arm64/kernel/process.c
> @@ -44,6 +44,7 @@
> #include <linux/hw_breakpoint.h>
> #include <linux/personality.h>
> #include <linux/notifier.h>
> +#include <trace/events/power.h>
>
> #include <asm/compat.h>
> #include <asm/cacheflush.h>
> @@ -75,8 +76,10 @@ void arch_cpu_idle(void)
> * This should do all the clock switching and wait for interrupt
> * tricks
> */
> + trace_cpu_idle_rcuidle(1, smp_processor_id());
> cpu_do_idle();
> local_irq_enable();
> + trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, smp_processor_id());
> }
>
> #ifdef CONFIG_HOTPLUG_CPU
> --
> 2.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
next prev parent reply other threads:[~2015-09-16 14:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 14:23 [PATCH] arm64: add cpu_idle tracepoints to arch_cpu_idle Jisheng Zhang
2015-09-16 14:47 ` Lorenzo Pieralisi [this message]
2015-09-16 14:53 ` Jisheng Zhang
2015-09-16 15:11 ` Jisheng Zhang
2015-09-16 16:16 ` Lorenzo Pieralisi
2015-09-16 16:56 ` Jisheng Zhang
2015-10-19 17:47 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150916144738.GA23245@red-moon \
--to=lorenzo.pieralisi@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).