* [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
@ 2015-08-06 15:58 Sanchayan Maity
2015-08-21 12:11 ` maitysanchayan at gmail.com
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sanchayan Maity @ 2015-08-06 15:58 UTC (permalink / raw)
To: linux-arm-kernel
Add iio_hwmon node to expose the temperature channel on Vybrid
as hardware monitor device using the iio_hwmon driver.
Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
---
arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
index 39173bb..0993d66 100644
--- a/arch/arm/boot/dts/vfxxx.dtsi
+++ b/arch/arm/boot/dts/vfxxx.dtsi
@@ -597,5 +597,10 @@
status = "disabled";
};
};
+
+ iio_hwmon {
+ compatible = "iio-hwmon";
+ io-channels = <&adc0 16>;
+ };
};
};
--
2.5.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
2015-08-06 15:58 [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Sanchayan Maity
@ 2015-08-21 12:11 ` maitysanchayan at gmail.com
2015-09-06 4:32 ` Shawn Guo
2015-09-06 4:35 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: maitysanchayan at gmail.com @ 2015-08-21 12:11 UTC (permalink / raw)
To: linux-arm-kernel
Ping?
- Sanchayan.
On 15-08-06 21:28:22, Sanchayan Maity wrote:
> Add iio_hwmon node to expose the temperature channel on Vybrid
> as hardware monitor device using the iio_hwmon driver.
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 39173bb..0993d66 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -597,5 +597,10 @@
> status = "disabled";
> };
> };
> +
> + iio_hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 16>;
> + };
> };
> };
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
2015-08-06 15:58 [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Sanchayan Maity
2015-08-21 12:11 ` maitysanchayan at gmail.com
@ 2015-09-06 4:32 ` Shawn Guo
2015-09-07 8:49 ` maitysanchayan at gmail.com
2015-09-06 4:35 ` Shawn Guo
2 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2015-09-06 4:32 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> Add iio_hwmon node to expose the temperature channel on Vybrid
> as hardware monitor device using the iio_hwmon driver.
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 39173bb..0993d66 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -597,5 +597,10 @@
> status = "disabled";
> };
> };
> +
> + iio_hwmon {
Hyphen rather than underscore should be used in node name.
Shawn
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 16>;
> + };
> };
> };
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
2015-09-06 4:32 ` Shawn Guo
@ 2015-09-07 8:49 ` maitysanchayan at gmail.com
2015-09-17 1:04 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: maitysanchayan at gmail.com @ 2015-09-07 8:49 UTC (permalink / raw)
To: linux-arm-kernel
Hi Shawn,
On 15-09-06 12:32:32, Shawn Guo wrote:
> On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> > Add iio_hwmon node to expose the temperature channel on Vybrid
> > as hardware monitor device using the iio_hwmon driver.
> >
> > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > ---
> > arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> > index 39173bb..0993d66 100644
> > --- a/arch/arm/boot/dts/vfxxx.dtsi
> > +++ b/arch/arm/boot/dts/vfxxx.dtsi
> > @@ -597,5 +597,10 @@
> > status = "disabled";
> > };
> > };
> > +
> > + iio_hwmon {
>
> Hyphen rather than underscore should be used in node name.
As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi.
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570
http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246
So should this be changed?
Thanks.
- Sanchayan.
>
> Shawn
>
> > + compatible = "iio-hwmon";
> > + io-channels = <&adc0 16>;
> > + };
> > };
> > };
> > --
> > 2.5.0
> >
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
2015-09-07 8:49 ` maitysanchayan at gmail.com
@ 2015-09-17 1:04 ` Shawn Guo
0 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2015-09-17 1:04 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Sep 07, 2015 at 02:19:11PM +0530, maitysanchayan at gmail.com wrote:
> Hi Shawn,
>
> On 15-09-06 12:32:32, Shawn Guo wrote:
> > On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> > > Add iio_hwmon node to expose the temperature channel on Vybrid
> > > as hardware monitor device using the iio_hwmon driver.
> > >
> > > Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> > > ---
> > > arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> > > 1 file changed, 5 insertions(+)
> > >
> > > diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> > > index 39173bb..0993d66 100644
> > > --- a/arch/arm/boot/dts/vfxxx.dtsi
> > > +++ b/arch/arm/boot/dts/vfxxx.dtsi
> > > @@ -597,5 +597,10 @@
> > > status = "disabled";
> > > };
> > > };
> > > +
> > > + iio_hwmon {
> >
> > Hyphen rather than underscore should be used in node name.
>
> As per iio-bindings.txt I did this. It is the same in imx23.dtsi and imx28.dtsi.
>
> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/iio-bindings.txt#L85
> http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx23.dtsi#L570
> http://lxr.free-electrons.com/source/arch/arm/boot/dts/imx28.dtsi#L1246
Oh, sorry, all these should be caught earlier.
>
> So should this be changed?
Yeah, that would be nice, if the change doesn't break anything.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel
2015-08-06 15:58 [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Sanchayan Maity
2015-08-21 12:11 ` maitysanchayan at gmail.com
2015-09-06 4:32 ` Shawn Guo
@ 2015-09-06 4:35 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2015-09-06 4:35 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 06, 2015 at 09:28:22PM +0530, Sanchayan Maity wrote:
> Add iio_hwmon node to expose the temperature channel on Vybrid
> as hardware monitor device using the iio_hwmon driver.
>
> Signed-off-by: Sanchayan Maity <maitysanchayan@gmail.com>
> ---
> arch/arm/boot/dts/vfxxx.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/vfxxx.dtsi b/arch/arm/boot/dts/vfxxx.dtsi
> index 39173bb..0993d66 100644
> --- a/arch/arm/boot/dts/vfxxx.dtsi
> +++ b/arch/arm/boot/dts/vfxxx.dtsi
> @@ -597,5 +597,10 @@
> status = "disabled";
> };
> };
> +
> + iio_hwmon {
> + compatible = "iio-hwmon";
> + io-channels = <&adc0 16>;
> + };
Also, what's the reason that the node is being put under
aips-bus at 40080000 (aips1)?
Shawn
> };
> };
> --
> 2.5.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-17 1:04 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-06 15:58 [PATCH] ARM: dts: vfxxx: Add iio_hwmon node for ADC temperature channel Sanchayan Maity
2015-08-21 12:11 ` maitysanchayan at gmail.com
2015-09-06 4:32 ` Shawn Guo
2015-09-07 8:49 ` maitysanchayan at gmail.com
2015-09-17 1:04 ` Shawn Guo
2015-09-06 4:35 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).