From: jszhang@marvell.com (Jisheng Zhang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver
Date: Mon, 21 Sep 2015 20:06:11 +0800 [thread overview]
Message-ID: <20150921200611.5e55e9d5@xhacker> (raw)
In-Reply-To: <55FF09D5.6090707@gmail.com>
Dear Sebastian,
On Sun, 20 Sep 2015 21:32:37 +0200
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> wrote:
> > + BERLIN_PINCTRL_GROUP("SM_TDO", 0x0, 0x3, 0x12,
> > + BERLIN_PINCTRL_FUNCTION(0x0, "sm_tdo"),
> > + BERLIN_PINCTRL_FUNCTION(0x1, "sm_gpio2")),
> > + BERLIN_PINCTRL_GROUP("SM_URT0_TXD", 0x0, 0x3, 0x15,
> > + BERLIN_PINCTRL_FUNCTION(0x0, "sm_urt0_txd"),
>
> Please avoid abbreviating acronyms even more, we can afford the
> few extra bytes.
In the 2nd version, I kept using HW names, for example:
1. "urt0" as the function name,
2. "SM_URT0_TXD" as the pin name (group name)
to keep sync with HW, especially the pin names are the same as HW's, because
that's what HW doc, sch, etc. call them. IMHO, using a different name with HW
is not a good idea, what do you think?
Thanks,
Jisheng
next prev parent reply other threads:[~2015-09-21 12:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 10:02 [PATCH 0/5] arm64: berlin: add pinctrl support Jisheng Zhang
2015-09-19 10:02 ` [PATCH 1/5] pinctrl: berlin: regmap as an extra argument of berlin_pinctrl_probe() Jisheng Zhang
2015-09-19 10:02 ` [PATCH 2/5] pinctrl: berlin: add the berlin4ct pinctrl driver Jisheng Zhang
2015-09-20 19:32 ` Sebastian Hesselbarth
2015-09-21 7:27 ` Jisheng Zhang
2015-09-21 12:06 ` Jisheng Zhang [this message]
2015-09-19 10:02 ` [PATCH 3/5] arm64: berlin: add the pinctrl dependency for Marvell Berlin SoCs Jisheng Zhang
2015-09-19 10:02 ` [PATCH 4/5] pinctrl: dt-binding: document berlin4ct SoC Jisheng Zhang
2015-09-19 10:02 ` [PATCH 5/5] arm64: dts: berlin4ct: add the pinctrl node and muxing setup for uart0 Jisheng Zhang
2015-09-20 19:38 ` Sebastian Hesselbarth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150921200611.5e55e9d5@xhacker \
--to=jszhang@marvell.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).