linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: Steps to submit a new arch/arm port
Date: Tue, 22 Sep 2015 15:56:00 +0100	[thread overview]
Message-ID: <20150922145600.GZ21084@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <144297172.JfjI0hNJ9J@wuerfel>

On Tue, Sep 22, 2015 at 04:51:48PM +0200, Arnd Bergmann wrote:
> On Tuesday 22 September 2015 16:36:48 Mason wrote:
> > +config ARCH_TANGOX
> > +	bool "Sigma Designs Tango"
> > +	select CLKDEV_LOOKUP
> > +	select HAVE_CLK
> > +	select HAVE_SMP
> > +	select ARCH_REQUIRE_GPIOLIB
> > +	select ARCH_HAS_CPUFREQ
> > +	select CLKSRC_MMIO
> > +	select GENERIC_CLOCKEVENTS
> > +	select GENERIC_IRQ_CHIP
> > +	select ARCH_HAS_HOLES_MEMORYMODEL
> > +	select SPARSE_IRQ
> > +	help
> > +	  Support for Sigma Designs Tango platform.
> > +
> >  endchoice
> 
> Move this to the platform Kconfig file. Also, drop all the
> 'select' statements that are implied by ARCH_MULTIPLATFORM
> and ARCH_MULTI_V7

And any remaining select statements should be sorted alphanumerically,
and that goes for everywhere, especially when introducing a new select
statement.

> > diff --git a/arch/arm/mach-tangox/Kconfig b/arch/arm/mach-tangox/Kconfig
> > new file mode 100644
> > index 000000000000..aba4eef9227c
> > --- /dev/null
> > +++ b/arch/arm/mach-tangox/Kconfig
> > @@ -0,0 +1,48 @@
> > +if ARCH_TANGOX
> > +
> > +config UNCOMPRESS_INCLUDE
> > +	string
> > +	default "debug/uncompress.h"
> 
> Better do this like everyone else.
> 
> > +config ARM_L1_CACHE_SHIFT
> > +	int
> > +	default 5
> 
> This conflicts with the other definition of the same symbol.

Indeed - I really don't like that Kconfig doesn't error out over this
kind of thing.

-- 
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2015-09-22 14:56 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 15:00 Steps to submit a new arch/arm port Mason
2015-09-21 15:49 ` Arnd Bergmann
2015-09-22 14:36   ` Mason
2015-09-22 14:51     ` Arnd Bergmann
2015-09-22 14:56       ` Russell King - ARM Linux [this message]
2015-09-22 15:54       ` Mason
2015-09-22 16:29         ` Russell King - ARM Linux
2015-09-23  8:49           ` Mason
2015-09-23  9:13             ` Russell King - ARM Linux
2015-09-23  9:21               ` Mason
2015-09-23  9:26                 ` Russell King - ARM Linux
2015-09-22 19:15         ` Arnd Bergmann
2015-09-23  9:26           ` Mason
2015-09-23  9:34             ` Arnd Bergmann
2015-09-25 13:06       ` Mason
2015-09-25 13:17         ` Arnd Bergmann
2015-09-25 13:35           ` Mason
2015-09-25 14:11             ` Arnd Bergmann
2015-09-25 15:28               ` Mason
2015-09-25 15:33                 ` Mason
2015-09-25 15:49                   ` Arnd Bergmann
2015-09-25 15:52                 ` Arnd Bergmann
2015-09-25 16:09                   ` Mason
2015-09-25 17:20                     ` Arnd Bergmann
2015-09-28 13:48       ` Mason
2015-09-28 14:43         ` Måns Rullgård
2015-09-28 16:32         ` Mason
2015-09-28 17:29           ` Russell King - ARM Linux
2015-09-22 15:48     ` Måns Rullgård
2015-09-25  9:27   ` Mason
2015-09-25  9:46     ` Javier Martinez Canillas
2015-09-25 11:56     ` Arnd Bergmann
2015-09-25 12:06     ` Russell King - ARM Linux
2015-09-21 15:51 ` Måns Rullgård
2015-09-21 16:13 ` Russell King - ARM Linux
2015-09-22 16:08   ` Mason
2015-09-22 16:24     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150922145600.GZ21084@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).