* [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it
@ 2015-09-22 11:45 Tobias Klauser
2015-09-22 16:03 ` Sören Brinkmann
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Tobias Klauser @ 2015-09-22 11:45 UTC (permalink / raw)
To: linux-arm-kernel
Use of_property_read_u32 instead of of_get_property with return value
checks and endianness conversion.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
index 2a5a168..507bbb0 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
@@ -129,7 +129,6 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
{
int ret;
u32 clk_div, host_clock;
- u32 *property_p;
struct mii_bus *bus;
struct resource res;
struct device_node *np1;
@@ -168,8 +167,7 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
clk_div = DEFAULT_CLOCK_DIVISOR;
goto issue;
}
- property_p = (u32 *) of_get_property(np1, "clock-frequency", NULL);
- if (!property_p) {
+ if (of_property_read_u32(np1, "clock-frequency", &host_clock)) {
netdev_warn(lp->ndev, "clock-frequency property not found.\n");
netdev_warn(lp->ndev,
"Setting MDIO clock divisor to default %d\n",
@@ -179,7 +177,6 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
goto issue;
}
- host_clock = be32_to_cpup(property_p);
clk_div = (host_clock / (MAX_MDIO_FREQ * 2)) - 1;
/* If there is any remainder from the division of
* fHOST / (MAX_MDIO_FREQ * 2), then we need to add
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it
2015-09-22 11:45 [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it Tobias Klauser
@ 2015-09-22 16:03 ` Sören Brinkmann
2015-09-23 7:20 ` [PATCH v2] " Tobias Klauser
2015-09-24 21:30 ` [PATCH] " David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Sören Brinkmann @ 2015-09-22 16:03 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2015-09-22 at 01:45PM +0200, Tobias Klauser wrote:
> Use of_property_read_u32 instead of of_get_property with return value
> checks and endianness conversion.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Reviewed-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>
S?ren
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] net: axinet: Use of_property_read_u32 instead of open-coding it
2015-09-22 11:45 [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it Tobias Klauser
2015-09-22 16:03 ` Sören Brinkmann
@ 2015-09-23 7:20 ` Tobias Klauser
2015-09-24 21:30 ` [PATCH] " David Miller
2 siblings, 0 replies; 4+ messages in thread
From: Tobias Klauser @ 2015-09-23 7:20 UTC (permalink / raw)
To: linux-arm-kernel
Use of_property_read_u32 instead of of_get_property with return value
checks and endianness conversion.
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Reviewed-by: S?ren Brinkmann <soren.brinkmann@xilinx.com>
---
v2: Resending with Cc to netdev
drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
index 2a5a168..507bbb0 100644
--- a/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
+++ b/drivers/net/ethernet/xilinx/xilinx_axienet_mdio.c
@@ -129,7 +129,6 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
{
int ret;
u32 clk_div, host_clock;
- u32 *property_p;
struct mii_bus *bus;
struct resource res;
struct device_node *np1;
@@ -168,8 +167,7 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
clk_div = DEFAULT_CLOCK_DIVISOR;
goto issue;
}
- property_p = (u32 *) of_get_property(np1, "clock-frequency", NULL);
- if (!property_p) {
+ if (of_property_read_u32(np1, "clock-frequency", &host_clock)) {
netdev_warn(lp->ndev, "clock-frequency property not found.\n");
netdev_warn(lp->ndev,
"Setting MDIO clock divisor to default %d\n",
@@ -179,7 +177,6 @@ int axienet_mdio_setup(struct axienet_local *lp, struct device_node *np)
goto issue;
}
- host_clock = be32_to_cpup(property_p);
clk_div = (host_clock / (MAX_MDIO_FREQ * 2)) - 1;
/* If there is any remainder from the division of
* fHOST / (MAX_MDIO_FREQ * 2), then we need to add
--
2.5.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it
2015-09-22 11:45 [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it Tobias Klauser
2015-09-22 16:03 ` Sören Brinkmann
2015-09-23 7:20 ` [PATCH v2] " Tobias Klauser
@ 2015-09-24 21:30 ` David Miller
2 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2015-09-24 21:30 UTC (permalink / raw)
To: linux-arm-kernel
From: Tobias Klauser <tklauser@distanz.ch>
Date: Tue, 22 Sep 2015 13:45:57 +0200
> Use of_property_read_u32 instead of of_get_property with return value
> checks and endianness conversion.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied to net-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-24 21:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-22 11:45 [PATCH] net: axinet: Use of_property_read_u32 instead of open-coding it Tobias Klauser
2015-09-22 16:03 ` Sören Brinkmann
2015-09-23 7:20 ` [PATCH v2] " Tobias Klauser
2015-09-24 21:30 ` [PATCH] " David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox