linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v5 0/4] arm/arm64: fix a migrating irq bug when hotplug cpu
Date: Tue, 22 Sep 2015 19:34:07 +0100	[thread overview]
Message-ID: <20150922183407.GP7356@arm.com> (raw)
In-Reply-To: <1442631959-10228-1-git-send-email-yangyingliang@huawei.com>

On Sat, Sep 19, 2015 at 04:05:55AM +0100, Yang Yingliang wrote:
> ----
> Changes in v5:
>  - remove the macro that guard move_irqs()
>  - use name irq_migrate_all_off_this_cpu instead of move_irqs
> 
> Changes in v4:
>  - select GENERIC_IRQ_MIGRATION when config GENERIC_IRQ_MIGRATION is enabled
>  - add move_irqs() into kerne/irq/migration.c for cpu hotplug
>  - use move_irqs() to migrate interrupts on arm/arm64 when cpu is going to down
>  - split bugfix patch into seperate patches for arm and arm64
> 
> Changes in v3:
>  - introduce config GENERIC_IRQ_MIGRATION for compiling migration.c
>  - rename migrate_irqs in arch/ia64/kernel/irq.c to avoid compiling error
> 
> Changes in v2:
>  - use the exiting helper to set IRQD_MOVE_PCNTXT flag
>  - use for_each_active_irq() instead of for_each_irq_desc()
>  - add some warn messages when affinity is null or do set affinity failed
> ----
> 
> Hi All,
> 
> There is a bug:
> 
> When cpu is disabled, all irqs will be migratged to another cpu.
> In some cases, a new affinity is different, it needed to be coppied
> to irq's affinity. But if the type of irq is LPI, it's affinity will
> not be coppied because of irq_set_affinity's return value.

This series looks good to me:

  Reviewed-by: Will Deacon <will.deacon@arm.com>

Marc: once you're happy with the irq/core changes, feel free to include
the arm64 patch in your tree.

Will

      parent reply	other threads:[~2015-09-22 18:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-19  3:05 [RFC PATCH v5 0/4] arm/arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-19  3:05 ` [RFC PATCH v5 1/4] genirq: introduce CONFIG_GENERIC_IRQ_MIGRATION Yang Yingliang
2015-09-22 18:49   ` Marc Zyngier
2015-09-19  3:05 ` [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug Yang Yingliang
2015-09-22 18:48   ` Marc Zyngier
2015-09-22 18:54   ` Thomas Gleixner
2015-09-23  4:16     ` Yang Yingliang
2015-09-23  8:02       ` Thomas Gleixner
2015-09-19  3:05 ` [RFC PATCH v5 3/4] arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-22 18:44   ` Marc Zyngier
2015-09-19  3:05 ` [RFC PATCH v5 4/4] arm: " Yang Yingliang
2015-09-22 18:50   ` Marc Zyngier
2015-09-22 18:34 ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150922183407.GP7356@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).