From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Tue, 22 Sep 2015 19:44:56 +0100 Subject: [RFC PATCH v5 3/4] arm64: fix a migrating irq bug when hotplug cpu In-Reply-To: <1442631959-10228-4-git-send-email-yangyingliang@huawei.com> References: <1442631959-10228-1-git-send-email-yangyingliang@huawei.com> <1442631959-10228-4-git-send-email-yangyingliang@huawei.com> Message-ID: <20150922194456.6b7e65ca@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 19 Sep 2015 11:05:58 +0800 Yang Yingliang wrote: > When cpu is disabled, all irqs will be migratged to another cpu. > In some cases, a new affinity is different, it needed to be coppied > to irq's affinity. But if the type of irq is LPI, it's affinity will > not be coppied because of irq_set_affinity's return value. Fix it by > using irq_do_set_affinity. Nit: This hasn't much to do with LPIs proper, but with the fact that the architecture code only has a partial knowledge of the possible affinity setting return values. > And migrating interrupts is a core code matter, so use the generic > function irq_migrate_all_off_this_cpu() to migrate interrupts in > kernel/irq/migration.c. > > Cc: Jiang Liu > Cc: Thomas Gleixner > Cc: Marc Zyngier > Cc: Mark Rutland > Cc: Will Deacon > Cc: Russell King - ARM Linux > Cc: Hanjun Guo > Signed-off-by: Yang Yingliang Otherwise Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.