From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCHv3] arm64: dts: Add base stratix 10 dtsi
Date: Wed, 23 Sep 2015 07:25:11 +0100 [thread overview]
Message-ID: <20150923062511.GA5517@svinekod> (raw)
In-Reply-To: <CADhT+wccWpy9VhZv=yWRiA4tf1SO_1-EAu6_cc+UkPJOWX0Bpw@mail.gmail.com>
On Wed, Sep 23, 2015 at 11:43:25PM +0100, Dinh Nguyen wrote:
> On Wed, Sep 23, 2015 at 12:54 AM, Mark Rutland <mark.rutland@arm.com> wrote:
> >> +/ {
> >> + compatible = "altr,socfpga-stratix10";
> >> + #address-cells = <2>;
> >> + #size-cells = <2>;
> >
> > [...]
> >
> >> + soc {
> >> + #address-cells = <1>;
> >> + #size-cells = <1>;
> >> + compatible = "simple-bus";
> >> + device_type = "soc";
> >> + interrupt-parent = <&intc>;
> >
> > As far as I am aware, this requires a (non-empty) ranges property, given the
> > parent node has {address,size}-cells = <2>.
> >
> > Does the kernel not complain currently?
> >
>
> I do not see any complaints without ranges here, but with ranges, I get:
I'm surprised (and a little worried) that we don't warn in the absence of
ranges when #{address,size}-cells changes. That doesn't feel right.
> DTC arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dtb
> Warning (ranges_format): /soc has empty "ranges" property but its
> #address-cells (1) differs from / (2)
> Warning (ranges_format): /soc has empty "ranges" property but its
> #size-cells (1) differs from / (2)
As I mentioned, the ranges proeprty should be non-empty.
Thanks,
Mark.
next prev parent reply other threads:[~2015-09-23 6:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-15 21:47 [RESEND PATCHv3] arm64: dts: Add base stratix 10 dtsi dinguyen at opensource.altera.com
2015-09-23 5:54 ` Mark Rutland
2015-09-23 22:43 ` Dinh Nguyen
2015-09-23 6:25 ` Mark Rutland [this message]
2015-09-23 19:30 ` Dinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923062511.GA5517@svinekod \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).