linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: imx7d: Fix UART2 base address
@ 2015-09-24 19:18 Fabio Estevam
  2015-09-26  5:01 ` Shawn Guo
  2015-09-30  1:50 ` Shawn Guo
  0 siblings, 2 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-09-24 19:18 UTC (permalink / raw)
  To: linux-arm-kernel

From: Fabio Estevam <fabio.estevam@freescale.com>

The UART2 memory space starts at address 0x30890000 (UART2_URXD).

Fix it so that UART2 can be used.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/boot/dts/imx7d.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
index 15c2193..9569d0a 100644
--- a/arch/arm/boot/dts/imx7d.dtsi
+++ b/arch/arm/boot/dts/imx7d.dtsi
@@ -640,10 +640,10 @@
 				status = "disabled";
 			};
 
-			uart2: serial at 30870000 {
+			uart2: serial at 30890000 {
 				compatible = "fsl,imx7d-uart",
 					     "fsl,imx6q-uart";
-				reg = <0x30870000 0x10000>;
+				reg = <0x30890000 0x10000>;
 				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
 				clocks = <&clks IMX7D_UART2_ROOT_CLK>,
 					<&clks IMX7D_UART2_ROOT_CLK>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: imx7d: Fix UART2 base address
  2015-09-24 19:18 [PATCH] ARM: dts: imx7d: Fix UART2 base address Fabio Estevam
@ 2015-09-26  5:01 ` Shawn Guo
  2015-09-28 23:37   ` Fabio Estevam
  2015-09-29  0:17   ` Nitin Garg
  2015-09-30  1:50 ` Shawn Guo
  1 sibling, 2 replies; 8+ messages in thread
From: Shawn Guo @ 2015-09-26  5:01 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 24, 2015 at 04:18:12PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The UART2 memory space starts at address 0x30890000 (UART2_URXD).
> 
> Fix it so that UART2 can be used.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Frank, can you confirm it?

Shawn

> ---
>  arch/arm/boot/dts/imx7d.dtsi | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
> index 15c2193..9569d0a 100644
> --- a/arch/arm/boot/dts/imx7d.dtsi
> +++ b/arch/arm/boot/dts/imx7d.dtsi
> @@ -640,10 +640,10 @@
>  				status = "disabled";
>  			};
>  
> -			uart2: serial at 30870000 {
> +			uart2: serial at 30890000 {
>  				compatible = "fsl,imx7d-uart",
>  					     "fsl,imx6q-uart";
> -				reg = <0x30870000 0x10000>;
> +				reg = <0x30890000 0x10000>;
>  				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
>  				clocks = <&clks IMX7D_UART2_ROOT_CLK>,
>  					<&clks IMX7D_UART2_ROOT_CLK>;
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: imx7d: Fix UART2 base address
  2015-09-26  5:01 ` Shawn Guo
@ 2015-09-28 23:37   ` Fabio Estevam
  2015-09-30  1:51     ` Shawn Guo
  2015-09-29  0:17   ` Nitin Garg
  1 sibling, 1 reply; 8+ messages in thread
From: Fabio Estevam @ 2015-09-28 23:37 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Shawn,

On Sat, Sep 26, 2015 at 2:01 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Thu, Sep 24, 2015 at 04:18:12PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> The UART2 memory space starts at address 0x30890000 (UART2_URXD).
>>
>> Fix it so that UART2 can be used.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>
> Frank, can you confirm it?

This patch uses the UART2 base address as stated in the MX7D Reference Manual.

It has also been tested on a custom board.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: imx7d: Fix UART2 base address
  2015-09-26  5:01 ` Shawn Guo
  2015-09-28 23:37   ` Fabio Estevam
@ 2015-09-29  0:17   ` Nitin Garg
  2015-09-29  1:08     ` Zhi Li
  1 sibling, 1 reply; 8+ messages in thread
From: Nitin Garg @ 2015-09-29  0:17 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/26/2015 12:01 AM, Shawn Guo wrote:
> On Thu, Sep 24, 2015 at 04:18:12PM -0300, Fabio Estevam wrote:
>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> The UART2 memory space starts at address 0x30890000 (UART2_URXD).
>>
>> Fix it so that UART2 can be used.
>>
>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> 
> Frank, can you confirm it?
> 
Shawn,
Yes, this change is correct. I confirmed in the SoC design db.

> Shawn
> 
>> ---
>>  arch/arm/boot/dts/imx7d.dtsi | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
>> index 15c2193..9569d0a 100644
>> --- a/arch/arm/boot/dts/imx7d.dtsi
>> +++ b/arch/arm/boot/dts/imx7d.dtsi
>> @@ -640,10 +640,10 @@
>>  				status = "disabled";
>>  			};
>>  
>> -			uart2: serial at 30870000 {
>> +			uart2: serial at 30890000 {
>>  				compatible = "fsl,imx7d-uart",
>>  					     "fsl,imx6q-uart";
>> -				reg = <0x30870000 0x10000>;
>> +				reg = <0x30890000 0x10000>;
>>  				interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
>>  				clocks = <&clks IMX7D_UART2_ROOT_CLK>,
>>  					<&clks IMX7D_UART2_ROOT_CLK>;
>> -- 
>> 1.9.1
>>
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> 

Regards,
Nitin

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: imx7d: Fix UART2 base address
  2015-09-29  0:17   ` Nitin Garg
@ 2015-09-29  1:08     ` Zhi Li
  0 siblings, 0 replies; 8+ messages in thread
From: Zhi Li @ 2015-09-29  1:08 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 28, 2015 at 7:17 PM, Nitin Garg <nitin.garg@freescale.com> wrote:
> On 09/26/2015 12:01 AM, Shawn Guo wrote:
>> On Thu, Sep 24, 2015 at 04:18:12PM -0300, Fabio Estevam wrote:
>>> From: Fabio Estevam <fabio.estevam@freescale.com>
>>>
>>> The UART2 memory space starts at address 0x30890000 (UART2_URXD).
>>>
>>> Fix it so that UART2 can be used.
>>>
>>> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
>>
>> Frank, can you confirm it?

Yes, it is correct.

best regards
Frank Li

>>
> Shawn,
> Yes, this change is correct. I confirmed in the SoC design db.
>
>> Shawn
>>
>>> ---
>>>  arch/arm/boot/dts/imx7d.dtsi | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi
>>> index 15c2193..9569d0a 100644
>>> --- a/arch/arm/boot/dts/imx7d.dtsi
>>> +++ b/arch/arm/boot/dts/imx7d.dtsi
>>> @@ -640,10 +640,10 @@
>>>                              status = "disabled";
>>>                      };
>>>
>>> -                    uart2: serial at 30870000 {
>>> +                    uart2: serial at 30890000 {
>>>                              compatible = "fsl,imx7d-uart",
>>>                                           "fsl,imx6q-uart";
>>> -                            reg = <0x30870000 0x10000>;
>>> +                            reg = <0x30890000 0x10000>;
>>>                              interrupts = <GIC_SPI 27 IRQ_TYPE_LEVEL_HIGH>;
>>>                              clocks = <&clks IMX7D_UART2_ROOT_CLK>,
>>>                                      <&clks IMX7D_UART2_ROOT_CLK>;
>>> --
>>> 1.9.1
>>>
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>>
>
> Regards,
> Nitin
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: imx7d: Fix UART2 base address
  2015-09-24 19:18 [PATCH] ARM: dts: imx7d: Fix UART2 base address Fabio Estevam
  2015-09-26  5:01 ` Shawn Guo
@ 2015-09-30  1:50 ` Shawn Guo
  1 sibling, 0 replies; 8+ messages in thread
From: Shawn Guo @ 2015-09-30  1:50 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 24, 2015 at 04:18:12PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@freescale.com>
> 
> The UART2 memory space starts at address 0x30890000 (UART2_URXD).
> 
> Fix it so that UART2 can be used.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>

Applied, thanks.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: imx7d: Fix UART2 base address
  2015-09-28 23:37   ` Fabio Estevam
@ 2015-09-30  1:51     ` Shawn Guo
  2015-09-30  1:54       ` Fabio Estevam
  0 siblings, 1 reply; 8+ messages in thread
From: Shawn Guo @ 2015-09-30  1:51 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 28, 2015 at 08:37:16PM -0300, Fabio Estevam wrote:
> Hi Shawn,
> 
> On Sat, Sep 26, 2015 at 2:01 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> > On Thu, Sep 24, 2015 at 04:18:12PM -0300, Fabio Estevam wrote:
> >> From: Fabio Estevam <fabio.estevam@freescale.com>
> >>
> >> The UART2 memory space starts at address 0x30890000 (UART2_URXD).
> >>
> >> Fix it so that UART2 can be used.
> >>
> >> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> >
> > Frank, can you confirm it?
> 
> This patch uses the UART2 base address as stated in the MX7D Reference Manual.

Is the Reference Manual published somewhere?

Shawn

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] ARM: dts: imx7d: Fix UART2 base address
  2015-09-30  1:51     ` Shawn Guo
@ 2015-09-30  1:54       ` Fabio Estevam
  0 siblings, 0 replies; 8+ messages in thread
From: Fabio Estevam @ 2015-09-30  1:54 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Shawn,

On Tue, Sep 29, 2015 at 10:51 PM, Shawn Guo <shawnguo@kernel.org> wrote:

>> This patch uses the UART2 base address as stated in the MX7D Reference Manual.
>
> Is the Reference Manual published somewhere?

It is not publicly available at this time

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2015-09-30  1:54 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-24 19:18 [PATCH] ARM: dts: imx7d: Fix UART2 base address Fabio Estevam
2015-09-26  5:01 ` Shawn Guo
2015-09-28 23:37   ` Fabio Estevam
2015-09-30  1:51     ` Shawn Guo
2015-09-30  1:54       ` Fabio Estevam
2015-09-29  0:17   ` Nitin Garg
2015-09-29  1:08     ` Zhi Li
2015-09-30  1:50 ` Shawn Guo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).