From mboxrd@z Thu Jan 1 00:00:00 1970 From: lkp@intel.com (kbuild test robot) Date: Mon, 28 Sep 2015 17:10:29 +0800 Subject: [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings In-Reply-To: <1443417278-19657-2-git-send-email-songjun.wu@atmel.com> References: <201509281735.7lYs3Huz%fengguang.wu@intel.com> Message-ID: <20150928091029.GA23312@roam> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579 PTR_ERR should access the value just tested by IS_ERR Semantic patch information: There can be false positives in the patch case, where it is the call IS_ERR that is wrong. Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci CC: Songjun Wu Signed-off-by: Fengguang Wu --- atmel-classd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/sound/soc/atmel/atmel-classd.c +++ b/sound/soc/atmel/atmel-classd.c @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla dd->gclk = devm_clk_get(dev, "gclk"); if (IS_ERR(dd->aclk)) { - ret = PTR_ERR(dd->gclk); + ret = PTR_ERR(dd->aclk); dev_err(dev, "failed to get GCK clock: %d\n", ret); return ret; }