linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS
Date: Tue, 29 Sep 2015 21:36:44 +0200	[thread overview]
Message-ID: <20150929193644.GS7104@lukather> (raw)
In-Reply-To: <560165EC.4050208@redhat.com>

On Tue, Sep 22, 2015 at 04:30:04PM +0200, Hans de Goede wrote:
> Hi,
> 
> On 22-09-15 16:04, Maxime Ripard wrote:
> >On Tue, Sep 22, 2015 at 03:01:58PM +0200, Hans de Goede wrote:
> >>>In short, this is not about "power supply" but VBUS detection. IIRC,
> >>>if no VBUS detection method is provided, the phy driver just waits a
> >>>period of time after an ID pin change and then considers VBUS invalid.
> >>
> >>Right, but that is a hack for boards with no / broken vbus detection
> >>(or vbus control), we really want to use vbus-det where available,
> >>so I agree that a TODO comment here would be good.
> >
> >What's so special in our SoCs that makes that we can't just rely on
> >the ID pin ? (which seems to be working just fine here)
> 
> There is nothing special, AFAIK all OTG ports (also for other SoCs)
> have some sort of vbus detection mechanism. We need the hack because
> vbus-det is broken on some of our boards.
> 
> And where it is not broken we should be using vbus-det normallu.

Ah, and most controllers embed that directly into the controller
itself and don't rely on a GPIO to do that. Understood.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20150929/f3a3e957/attachment-0001.sig>

  reply	other threads:[~2015-09-29 19:36 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18  8:48 [PATCH 0/5] ARM: sunxi: Introduce CHIP support Maxime Ripard
2015-09-18  8:48 ` [PATCH 1/5] ARM: sunxi: Add R8 support Maxime Ripard
2015-09-18  9:47   ` Chen-Yu Tsai
2015-09-18 12:20     ` Maxime Ripard
2015-09-30 22:38   ` Stephen Boyd
2015-10-01  6:58     ` Maxime Ripard
2015-09-18  8:48 ` [PATCH 2/5] ARM: sun5i: Add R8 DTSI Maxime Ripard
2015-09-18  9:41   ` Chen-Yu Tsai
2015-09-18 12:19     ` Maxime Ripard
2015-09-18  8:48 ` [PATCH 3/5] ARM: sun5i: dt: Move uart3 pinctrl node to common DTSI Maxime Ripard
2015-09-18  8:48 ` [PATCH 4/5] ARM: sun5i: dt: Add UART3 CTS and RTS pins Maxime Ripard
2015-09-18  8:48 ` [PATCH 5/5] ARM: sun5i: Add C.H.I.P DTS Maxime Ripard
2015-09-18 16:41   ` Chen-Yu Tsai
2015-09-22 12:47     ` Maxime Ripard
2015-09-22 12:57       ` [linux-sunxi] " Chen-Yu Tsai
2015-09-22 13:01         ` Hans de Goede
2015-09-22 13:34           ` Hans de Goede
2015-09-22 14:04           ` Maxime Ripard
2015-09-22 14:30             ` Hans de Goede
2015-09-29 19:36               ` Maxime Ripard [this message]
2015-09-18  9:02 ` [PATCH 0/5] ARM: sunxi: Introduce CHIP support Arnd Bergmann
2015-09-18 12:19   ` Maxime Ripard
2015-09-18 13:18     ` Arnd Bergmann
2015-09-18 13:55       ` Maxime Ripard
2015-09-18 13:58         ` Arnd Bergmann
2015-09-18 15:36 ` [linux-sunxi] " Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150929193644.GS7104@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).