From: ckeepax@opensource.wolfsonmicro.com (Charles Keepax)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed
Date: Wed, 30 Sep 2015 14:15:22 +0100 [thread overview]
Message-ID: <20150930131522.GK5432@ck-lbox> (raw)
In-Reply-To: <560BC6ED.3090205@samsung.com>
On Wed, Sep 30, 2015 at 08:26:37PM +0900, Inki Dae wrote:
> Hi,
>
> On 2015? 09? 28? 01:11, Charles Keepax wrote:
> > If binding failed calling exynos_dp_enable in exynos_dp_resume will
> > result in several NULL pointer dereferences. It is much better to
> > simply skip suspend/resume handling if bind has failed, do so by
> > checking if a drm_dev exists.
>
> Thanks for your patch. However, the pm interfaces of KMS drivers aren't
> required because these are controlled by top of Exynos drm driver and
> connector dpms. So I posted a patch that it removes pm interfaces of dp
> driver.
No problems at all, as long as my Arndale starts resuming without
a NULL pointer I am happy :-)
Had a quick test of your patch it appears to fix my issue as well
so totally fine with that.
Thanks,
Charles
prev parent reply other threads:[~2015-09-30 13:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-27 16:11 [PATCH] drm/exynos: Avoid NULL pointer dereference in resume if bind failed Charles Keepax
2015-09-30 11:26 ` Inki Dae
2015-09-30 13:15 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150930131522.GK5432@ck-lbox \
--to=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).