* [PATCH] thermal: exynos: fix register read in TMU
@ 2015-10-01 11:39 Sudip Mukherjee
2015-10-01 13:18 ` Krzysztof Kozlowski
2015-10-02 0:03 ` Chanwoo Choi
0 siblings, 2 replies; 11+ messages in thread
From: Sudip Mukherjee @ 2015-10-01 11:39 UTC (permalink / raw)
To: linux-arm-kernel
The value of emul_con was getting overwritten if the selected soc is
SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
register in the case of SOC_ARCH_EXYNOS5260.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/thermal/samsung/exynos_tmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 0bae8cc..ca920b0 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
if (data->soc == SOC_ARCH_EXYNOS5260)
emul_con = EXYNOS5260_EMUL_CON;
- if (data->soc == SOC_ARCH_EXYNOS5433)
+ else if (data->soc == SOC_ARCH_EXYNOS5433)
emul_con = EXYNOS5433_TMU_EMUL_CON;
else if (data->soc == SOC_ARCH_EXYNOS7)
emul_con = EXYNOS7_TMU_REG_EMUL_CON;
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] thermal: exynos: fix register read in TMU
2015-10-01 11:39 [PATCH] thermal: exynos: fix register read in TMU Sudip Mukherjee
@ 2015-10-01 13:18 ` Krzysztof Kozlowski
2015-10-01 14:12 ` Sudip Mukherjee
2015-10-02 0:03 ` Chanwoo Choi
1 sibling, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-01 13:18 UTC (permalink / raw)
To: linux-arm-kernel
2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> The value of emul_con was getting overwritten if the selected soc is
> SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
> register in the case of SOC_ARCH_EXYNOS5260.
How the value is overwritten if the soc is Exynos5260? I can't see it
(although the "else if" is still more obvious than "if" but how does
the description match the code?).
Best regards,
Krzysztof
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 0bae8cc..ca920b0 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
>
> if (data->soc == SOC_ARCH_EXYNOS5260)
> emul_con = EXYNOS5260_EMUL_CON;
> - if (data->soc == SOC_ARCH_EXYNOS5433)
> + else if (data->soc == SOC_ARCH_EXYNOS5433)
> emul_con = EXYNOS5433_TMU_EMUL_CON;
> else if (data->soc == SOC_ARCH_EXYNOS7)
> emul_con = EXYNOS7_TMU_REG_EMUL_CON;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] thermal: exynos: fix register read in TMU
2015-10-01 13:18 ` Krzysztof Kozlowski
@ 2015-10-01 14:12 ` Sudip Mukherjee
2015-10-01 23:43 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Sudip Mukherjee @ 2015-10-01 14:12 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote:
> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> > The value of emul_con was getting overwritten if the selected soc is
> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
> > register in the case of SOC_ARCH_EXYNOS5260.
>
> How the value is overwritten if the soc is Exynos5260? I can't see it
> (although the "else if" is still more obvious than "if" but how does
> the description match the code?).
The code here is:
if (data->soc == SOC_ARCH_EXYNOS5260)
emul_con = EXYNOS5260_EMUL_CON;
if (data->soc == SOC_ARCH_EXYNOS5433)
emul_con = EXYNOS5433_TMU_EMUL_CON;
else if (data->soc == SOC_ARCH_EXYNOS7)
emul_con = EXYNOS7_TMU_REG_EMUL_CON;
else
emul_con = EXYNOS_EMUL_CON;
So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
EXYNOS5260_EMUL_CON. But again for the else part it will become
EXYNOS_EMUL_CON.
regards
sudip
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] thermal: exynos: fix register read in TMU
2015-10-01 14:12 ` Sudip Mukherjee
@ 2015-10-01 23:43 ` Krzysztof Kozlowski
2015-10-08 14:21 ` Sudip Mukherjee
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-01 23:43 UTC (permalink / raw)
To: linux-arm-kernel
2015-10-01 23:12 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote:
>> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
>> > The value of emul_con was getting overwritten if the selected soc is
>> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
>> > register in the case of SOC_ARCH_EXYNOS5260.
>>
>> How the value is overwritten if the soc is Exynos5260? I can't see it
>> (although the "else if" is still more obvious than "if" but how does
>> the description match the code?).
> The code here is:
> if (data->soc == SOC_ARCH_EXYNOS5260)
> emul_con = EXYNOS5260_EMUL_CON;
> if (data->soc == SOC_ARCH_EXYNOS5433)
> emul_con = EXYNOS5433_TMU_EMUL_CON;
> else if (data->soc == SOC_ARCH_EXYNOS7)
> emul_con = EXYNOS7_TMU_REG_EMUL_CON;
> else
> emul_con = EXYNOS_EMUL_CON;
>
> So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
> EXYNOS5260_EMUL_CON. But again for the else part it will become
> EXYNOS_EMUL_CON.
Indeed!
Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH] thermal: exynos: fix register read in TMU
2015-10-01 23:43 ` Krzysztof Kozlowski
@ 2015-10-08 14:21 ` Sudip Mukherjee
2015-10-09 11:35 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Sudip Mukherjee @ 2015-10-08 14:21 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote:
> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote:
> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> >> > The value of emul_con was getting overwritten if the selected soc is
> >> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
> >> > register in the case of SOC_ARCH_EXYNOS5260.
> >>
> >> How the value is overwritten if the soc is Exynos5260? I can't see it
> >> (although the "else if" is still more obvious than "if" but how does
> >> the description match the code?).
> > The code here is:
> > if (data->soc == SOC_ARCH_EXYNOS5260)
> > emul_con = EXYNOS5260_EMUL_CON;
> > if (data->soc == SOC_ARCH_EXYNOS5433)
> > emul_con = EXYNOS5433_TMU_EMUL_CON;
> > else if (data->soc == SOC_ARCH_EXYNOS7)
> > emul_con = EXYNOS7_TMU_REG_EMUL_CON;
> > else
> > emul_con = EXYNOS_EMUL_CON;
> >
> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
> > EXYNOS5260_EMUL_CON. But again for the else part it will become
> > EXYNOS_EMUL_CON.
>
> Indeed!
>
> Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Hi Krzysztof,
Who will pick this one up? I still do not see it in linux-next.
regards
sudip
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH] thermal: exynos: fix register read in TMU
2015-10-08 14:21 ` Sudip Mukherjee
@ 2015-10-09 11:35 ` Krzysztof Kozlowski
2015-10-09 12:07 ` Lukasz Majewski
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-09 11:35 UTC (permalink / raw)
To: linux-arm-kernel
2015-10-08 23:21 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
> On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote:
>> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
>> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski wrote:
>> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee <sudipm.mukherjee@gmail.com>:
>> >> > The value of emul_con was getting overwritten if the selected soc is
>> >> > SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
>> >> > register in the case of SOC_ARCH_EXYNOS5260.
>> >>
>> >> How the value is overwritten if the soc is Exynos5260? I can't see it
>> >> (although the "else if" is still more obvious than "if" but how does
>> >> the description match the code?).
>> > The code here is:
>> > if (data->soc == SOC_ARCH_EXYNOS5260)
>> > emul_con = EXYNOS5260_EMUL_CON;
>> > if (data->soc == SOC_ARCH_EXYNOS5433)
>> > emul_con = EXYNOS5433_TMU_EMUL_CON;
>> > else if (data->soc == SOC_ARCH_EXYNOS7)
>> > emul_con = EXYNOS7_TMU_REG_EMUL_CON;
>> > else
>> > emul_con = EXYNOS_EMUL_CON;
>> >
>> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
>> > EXYNOS5260_EMUL_CON. But again for the else part it will become
>> > EXYNOS_EMUL_CON.
>>
>> Indeed!
>>
>> Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
>>
>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Hi Krzysztof,
> Who will pick this one up? I still do not see it in linux-next.
Hi!
I guess it is a patch for Lukasz.
Lukasz,
Do you plan to pick it up or maybe this should go through samsung-soc tree?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH] thermal: exynos: fix register read in TMU
2015-10-09 11:35 ` Krzysztof Kozlowski
@ 2015-10-09 12:07 ` Lukasz Majewski
2015-10-10 4:36 ` Krzysztof Kozlowski
0 siblings, 1 reply; 11+ messages in thread
From: Lukasz Majewski @ 2015-10-09 12:07 UTC (permalink / raw)
To: linux-arm-kernel
Hi Krzysztof,
> 2015-10-08 23:21 GMT+09:00 Sudip Mukherjee
> <sudipm.mukherjee@gmail.com>:
> > On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote:
> >> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee
> >> <sudipm.mukherjee@gmail.com>:
> >> > On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski
> >> > wrote:
> >> >> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee
> >> >> <sudipm.mukherjee@gmail.com>:
> >> >> > The value of emul_con was getting overwritten if the selected
> >> >> > soc is SOC_ARCH_EXYNOS5260. And so as a result we were
> >> >> > reading from the wrong register in the case of
> >> >> > SOC_ARCH_EXYNOS5260.
> >> >>
> >> >> How the value is overwritten if the soc is Exynos5260? I can't
> >> >> see it (although the "else if" is still more obvious than "if"
> >> >> but how does the description match the code?).
> >> > The code here is:
> >> > if (data->soc == SOC_ARCH_EXYNOS5260)
> >> > emul_con = EXYNOS5260_EMUL_CON;
> >> > if (data->soc == SOC_ARCH_EXYNOS5433)
> >> > emul_con = EXYNOS5433_TMU_EMUL_CON;
> >> > else if (data->soc == SOC_ARCH_EXYNOS7)
> >> > emul_con = EXYNOS7_TMU_REG_EMUL_CON;
> >> > else
> >> > emul_con = EXYNOS_EMUL_CON;
> >> >
> >> > So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
> >> > EXYNOS5260_EMUL_CON. But again for the else part it will become
> >> > EXYNOS_EMUL_CON.
> >>
> >> Indeed!
> >>
> >> Fixes: 488c7455d74c ("thermal: exynos: Add the support for
> >> Exynos5433 TMU")
> >>
> >> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
> > Hi Krzysztof,
> > Who will pick this one up? I still do not see it in linux-next.
>
> Hi!
>
> I guess it is a patch for Lukasz.
>
> Lukasz,
> Do you plan to pick it up or maybe this should go through samsung-soc
> tree?
This is the only one patch, which is waiting in my queue. Since no more
fixes available, please feel free to grab this patch to samsung-soc.
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Best regards,
> Krzysztof
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 11+ messages in thread* [PATCH] thermal: exynos: fix register read in TMU
2015-10-09 12:07 ` Lukasz Majewski
@ 2015-10-10 4:36 ` Krzysztof Kozlowski
0 siblings, 0 replies; 11+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-10 4:36 UTC (permalink / raw)
To: linux-arm-kernel
W dniu 09.10.2015 o 21:07, Lukasz Majewski pisze:
> Hi Krzysztof,
>
>> 2015-10-08 23:21 GMT+09:00 Sudip Mukherjee
>> <sudipm.mukherjee@gmail.com>:
>>> On Fri, Oct 02, 2015 at 08:43:52AM +0900, Krzysztof Kozlowski wrote:
>>>> 2015-10-01 23:12 GMT+09:00 Sudip Mukherjee
>>>> <sudipm.mukherjee@gmail.com>:
>>>>> On Thu, Oct 01, 2015 at 10:18:57PM +0900, Krzysztof Kozlowski
>>>>> wrote:
>>>>>> 2015-10-01 20:39 GMT+09:00 Sudip Mukherjee
>>>>>> <sudipm.mukherjee@gmail.com>:
>>>>>>> The value of emul_con was getting overwritten if the selected
>>>>>>> soc is SOC_ARCH_EXYNOS5260. And so as a result we were
>>>>>>> reading from the wrong register in the case of
>>>>>>> SOC_ARCH_EXYNOS5260.
>>>>>>
>>>>>> How the value is overwritten if the soc is Exynos5260? I can't
>>>>>> see it (although the "else if" is still more obvious than "if"
>>>>>> but how does the description match the code?).
>>>>> The code here is:
>>>>> if (data->soc == SOC_ARCH_EXYNOS5260)
>>>>> emul_con = EXYNOS5260_EMUL_CON;
>>>>> if (data->soc == SOC_ARCH_EXYNOS5433)
>>>>> emul_con = EXYNOS5433_TMU_EMUL_CON;
>>>>> else if (data->soc == SOC_ARCH_EXYNOS7)
>>>>> emul_con = EXYNOS7_TMU_REG_EMUL_CON;
>>>>> else
>>>>> emul_con = EXYNOS_EMUL_CON;
>>>>>
>>>>> So if data->soc is SOC_ARCH_EXYNOS5260 , then emul_con becomes
>>>>> EXYNOS5260_EMUL_CON. But again for the else part it will become
>>>>> EXYNOS_EMUL_CON.
>>>>
>>>> Indeed!
>>>>
>>>> Fixes: 488c7455d74c ("thermal: exynos: Add the support for
>>>> Exynos5433 TMU")
>>>>
>>>> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>
>>> Hi Krzysztof,
>>> Who will pick this one up? I still do not see it in linux-next.
>>
>> Hi!
>>
>> I guess it is a patch for Lukasz.
>>
>> Lukasz,
>> Do you plan to pick it up or maybe this should go through samsung-soc
>> tree?
>
> This is the only one patch, which is waiting in my queue. Since no more
> fixes available, please feel free to grab this patch to samsung-soc.
>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Okay, thanks! Applied to fixes for current cycle. I'll it send later to
Kukjin (unless he picks it as well).
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] thermal: exynos: fix register read in TMU
2015-10-01 11:39 [PATCH] thermal: exynos: fix register read in TMU Sudip Mukherjee
2015-10-01 13:18 ` Krzysztof Kozlowski
@ 2015-10-02 0:03 ` Chanwoo Choi
1 sibling, 0 replies; 11+ messages in thread
From: Chanwoo Choi @ 2015-10-02 0:03 UTC (permalink / raw)
To: linux-arm-kernel
On 2015? 10? 01? 20:39, Sudip Mukherjee wrote:
> The value of emul_con was getting overwritten if the selected soc is
> SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
> register in the case of SOC_ARCH_EXYNOS5260.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 0bae8cc..ca920b0 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
>
> if (data->soc == SOC_ARCH_EXYNOS5260)
> emul_con = EXYNOS5260_EMUL_CON;
> - if (data->soc == SOC_ARCH_EXYNOS5433)
> + else if (data->soc == SOC_ARCH_EXYNOS5433)
> emul_con = EXYNOS5433_TMU_EMUL_CON;
> else if (data->soc == SOC_ARCH_EXYNOS7)
> emul_con = EXYNOS7_TMU_REG_EMUL_CON;
>
Thanks for your point out. Looks good to me.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Thanks,
Chanwoo Choi
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] thermal: exynos: Fix register read in TMU
@ 2015-10-12 23:51 Krzysztof Kozlowski
2015-10-16 23:20 ` Kukjin Kim
0 siblings, 1 reply; 11+ messages in thread
From: Krzysztof Kozlowski @ 2015-10-12 23:51 UTC (permalink / raw)
To: linux-arm-kernel
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
The value of emul_con was getting overwritten if the selected soc is
SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
register in the case of SOC_ARCH_EXYNOS5260.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/thermal/samsung/exynos_tmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
index 0bae8cc6c23a..ca920b0ecf8f 100644
--- a/drivers/thermal/samsung/exynos_tmu.c
+++ b/drivers/thermal/samsung/exynos_tmu.c
@@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
if (data->soc == SOC_ARCH_EXYNOS5260)
emul_con = EXYNOS5260_EMUL_CON;
- if (data->soc == SOC_ARCH_EXYNOS5433)
+ else if (data->soc == SOC_ARCH_EXYNOS5433)
emul_con = EXYNOS5433_TMU_EMUL_CON;
else if (data->soc == SOC_ARCH_EXYNOS7)
emul_con = EXYNOS7_TMU_REG_EMUL_CON;
--
1.9.1
^ permalink raw reply related [flat|nested] 11+ messages in thread* [PATCH] thermal: exynos: Fix register read in TMU
2015-10-12 23:51 [PATCH] thermal: exynos: Fix " Krzysztof Kozlowski
@ 2015-10-16 23:20 ` Kukjin Kim
0 siblings, 0 replies; 11+ messages in thread
From: Kukjin Kim @ 2015-10-16 23:20 UTC (permalink / raw)
To: linux-arm-kernel
On 10/13/15 08:51, Krzysztof Kozlowski wrote:
> From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
>
> The value of emul_con was getting overwritten if the selected soc is
> SOC_ARCH_EXYNOS5260. And so as a result we were reading from the wrong
> register in the case of SOC_ARCH_EXYNOS5260.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Fixes: 488c7455d74c ("thermal: exynos: Add the support for Exynos5433 TMU")
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/thermal/samsung/exynos_tmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c
> index 0bae8cc6c23a..ca920b0ecf8f 100644
> --- a/drivers/thermal/samsung/exynos_tmu.c
> +++ b/drivers/thermal/samsung/exynos_tmu.c
> @@ -932,7 +932,7 @@ static void exynos4412_tmu_set_emulation(struct exynos_tmu_data *data,
>
> if (data->soc == SOC_ARCH_EXYNOS5260)
> emul_con = EXYNOS5260_EMUL_CON;
> - if (data->soc == SOC_ARCH_EXYNOS5433)
> + else if (data->soc == SOC_ARCH_EXYNOS5433)
> emul_con = EXYNOS5433_TMU_EMUL_CON;
> else if (data->soc == SOC_ARCH_EXYNOS7)
> emul_con = EXYNOS7_TMU_REG_EMUL_CON;
Applied, thanks.
- Kukjin
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-10-16 23:20 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-01 11:39 [PATCH] thermal: exynos: fix register read in TMU Sudip Mukherjee
2015-10-01 13:18 ` Krzysztof Kozlowski
2015-10-01 14:12 ` Sudip Mukherjee
2015-10-01 23:43 ` Krzysztof Kozlowski
2015-10-08 14:21 ` Sudip Mukherjee
2015-10-09 11:35 ` Krzysztof Kozlowski
2015-10-09 12:07 ` Lukasz Majewski
2015-10-10 4:36 ` Krzysztof Kozlowski
2015-10-02 0:03 ` Chanwoo Choi
-- strict thread matches above, loose matches on Subject: below --
2015-10-12 23:51 [PATCH] thermal: exynos: Fix " Krzysztof Kozlowski
2015-10-16 23:20 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).