From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 5/5] clk: sunxi: mod1 clock support
Date: Fri, 2 Oct 2015 13:45:55 -0700 [thread overview]
Message-ID: <20151002204555.GA12338@codeaurora.org> (raw)
In-Reply-To: <1443512353-28073-6-git-send-email-maxime.ripard@free-electrons.com>
On 09/29, Maxime Ripard wrote:
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <linux/clk-provider.h>
> +#include <linux/clkdev.h>
Is this include used?
> + if (!gate)
> + goto err_free_mux;
> +
> + of_property_read_string(node, "clock-output-names", &clk_name);
> +
> + while (i < SUN4I_MOD1_MAX_PARENTS &&
> + (parents[i] = of_clk_get_parent_name(node, i)) != NULL)
Can we use of_clk_parent_fill() here?
> + i++;
> +
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-02 20:45 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 7:39 [PATCH v3 0/5] clk: sunxi: Add support for the Audio PLL Maxime Ripard
2015-09-29 7:39 ` [PATCH v3 1/5] clk: Add a basic multiplier clock Maxime Ripard
2015-10-02 20:43 ` Stephen Boyd
2015-10-05 10:19 ` Maxime Ripard
2015-10-05 18:09 ` Stephen Boyd
2015-10-07 11:04 ` Maxime Ripard
2015-10-07 19:17 ` Stephen Boyd
2015-09-29 7:39 ` [PATCH v3 2/5] clk: sunxi: Add a driver for the PLL2 Maxime Ripard
2015-09-29 7:39 ` [PATCH v3 3/5] clk: sunxi: pll2: Add A13 support Maxime Ripard
2015-09-29 7:39 ` [PATCH v3 4/5] clk: sunxi: codec clock support Maxime Ripard
2015-10-02 20:44 ` Stephen Boyd
2015-10-05 9:05 ` Maxime Ripard
2015-09-29 7:39 ` [PATCH v3 5/5] clk: sunxi: mod1 " Maxime Ripard
2015-10-02 20:45 ` Stephen Boyd [this message]
2015-10-05 9:44 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151002204555.GA12338@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).