From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] irqchip: sunxi-nmi: Use driver name instead of DT node name for identification
Date: Tue, 6 Oct 2015 00:03:26 +0200 [thread overview]
Message-ID: <20151005220326.GP2696@lukather> (raw)
In-Reply-To: <1444063334-19832-2-git-send-email-wens@csie.org>
On Tue, Oct 06, 2015 at 12:42:13AM +0800, Chen-Yu Tsai wrote:
> The device tree node name is typically "interrupt-controller", which is
> rather useless when used in printk messages and irq chip names for
> identification purposes. Use the driver name "sunxi-nmi" instead.
>
> While at it move the identifier from pr_err() calls to the pr_fmt macro.
>
> Also remove the "__func__" identifier from the error message in the
> interrupt type setting callback, sunxi_sc_nmi_set_type(). The driver
> name in the pr_fmt macro should be enough.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151006/8c271434/attachment.sig>
next prev parent reply other threads:[~2015-10-05 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-05 16:42 [PATCH v2 0/2] irqchip: sunxi-nmi: misc. / aesthetic improvements Chen-Yu Tsai
2015-10-05 16:42 ` [PATCH v2 1/2] irqchip: sunxi-nmi: Use driver name instead of DT node name for identification Chen-Yu Tsai
2015-10-05 22:03 ` Maxime Ripard [this message]
2015-10-05 16:42 ` [PATCH v2 2/2] irqchip: sunxi-nmi: switch to of_io_request_and_map() from of_iomap() Chen-Yu Tsai
2015-10-05 22:02 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151005220326.GP2696@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).