* [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
@ 2015-10-06 20:28 Sylvain Rochet
2015-10-07 11:01 ` Alexandre Belloni
0 siblings, 1 reply; 6+ messages in thread
From: Sylvain Rochet @ 2015-10-06 20:28 UTC (permalink / raw)
To: linux-arm-kernel
Since turning on idle-halt in commit 5161b31dc39a (watchdog:
at91sam9_wdt: better watchdog support"), SoCs compatible with
at91sam9260-wdt not using a device tree no longer reboot if the watchdog
times out while the CPU is in idle state. Removing the
AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
Cc: <stable@vger.kernel.org> # 3.14+
---
drivers/watchdog/at91sam9_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/watchdog/at91sam9_wdt.c b/drivers/watchdog/at91sam9_wdt.c
index 7e6acaf..6e3a167 100644
--- a/drivers/watchdog/at91sam9_wdt.c
+++ b/drivers/watchdog/at91sam9_wdt.c
@@ -339,7 +339,7 @@ static int __init at91wdt_probe(struct platform_device *pdev)
return -ENOMEM;
wdt->mr = (WDT_HW_TIMEOUT * 256) | AT91_WDT_WDRSTEN | AT91_WDT_WDD |
- AT91_WDT_WDDBGHLT | AT91_WDT_WDIDLEHLT;
+ AT91_WDT_WDDBGHLT;
wdt->mr_mask = 0x3FFFFFFF;
wdt->nowayout = nowayout;
wdt->wdd.parent = &pdev->dev;
--
2.5.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
2015-10-06 20:28 [PATCH] watchdog: at91sam9: keep watchdog running in idle mode Sylvain Rochet
@ 2015-10-07 11:01 ` Alexandre Belloni
2016-10-16 15:33 ` Sylvain Rochet
0 siblings, 1 reply; 6+ messages in thread
From: Alexandre Belloni @ 2015-10-07 11:01 UTC (permalink / raw)
To: linux-arm-kernel
Hi Sylvain,
On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
> Since turning on idle-halt in commit 5161b31dc39a (watchdog:
> at91sam9_wdt: better watchdog support"), SoCs compatible with
> at91sam9260-wdt not using a device tree no longer reboot if the watchdog
> times out while the CPU is in idle state. Removing the
> AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
>
> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
> Cc: <stable@vger.kernel.org> # 3.14+
Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
However, we don't really care about that for kernels after 3.18 as no
users are using pdata anymore.
I think you could send a follow-up patch removing pdata support
completely.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
2015-10-07 11:01 ` Alexandre Belloni
@ 2016-10-16 15:33 ` Sylvain Rochet
2016-10-16 15:50 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Sylvain Rochet @ 2016-10-16 15:33 UTC (permalink / raw)
To: linux-arm-kernel
Hi,
On Wed, Oct 07, 2015 at 01:01:12PM +0200, Alexandre Belloni wrote:
> On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
> > Since turning on idle-halt in commit 5161b31dc39a (watchdog:
> > at91sam9_wdt: better watchdog support"), SoCs compatible with
> > at91sam9260-wdt not using a device tree no longer reboot if the watchdog
> > times out while the CPU is in idle state. Removing the
> > AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
> >
> > Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
> > Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
> > Cc: <stable@vger.kernel.org> # 3.14+
>
> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>
> However, we don't really care about that for kernels after 3.18 as no
> users are using pdata anymore.
> I think you could send a follow-up patch removing pdata support
> completely.
Looks like this one falls through the cracks, it didn't reach mainline
and therefore wasn't applied to stable branches.
I just checked, it still apply properly on today's linux-next branch.
Cheers,
Sylvain
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
2016-10-16 15:33 ` Sylvain Rochet
@ 2016-10-16 15:50 ` Guenter Roeck
2016-10-16 15:55 ` Guenter Roeck
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2016-10-16 15:50 UTC (permalink / raw)
To: linux-arm-kernel
On 10/16/2016 08:33 AM, Sylvain Rochet wrote:
> Hi,
>
> On Wed, Oct 07, 2015 at 01:01:12PM +0200, Alexandre Belloni wrote:
>> On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
>>> Since turning on idle-halt in commit 5161b31dc39a (watchdog:
>>> at91sam9_wdt: better watchdog support"), SoCs compatible with
>>> at91sam9260-wdt not using a device tree no longer reboot if the watchdog
>>> times out while the CPU is in idle state. Removing the
>>> AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
>>>
>>> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
>>> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
>>> Cc: <stable@vger.kernel.org> # 3.14+
>>
>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>
>> However, we don't really care about that for kernels after 3.18 as no
>> users are using pdata anymore.
>> I think you could send a follow-up patch removing pdata support
>> completely.
>
> Looks like this one falls through the cracks, it didn't reach mainline
> and therefore wasn't applied to stable branches.
>
Possibly that happened because you did not copy the watchdog mailing list.
Guenter
> I just checked, it still apply properly on today's linux-next branch.
>
> Cheers,
> Sylvain
>
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
2016-10-16 15:50 ` Guenter Roeck
@ 2016-10-16 15:55 ` Guenter Roeck
2016-10-16 20:39 ` Sylvain Rochet
0 siblings, 1 reply; 6+ messages in thread
From: Guenter Roeck @ 2016-10-16 15:55 UTC (permalink / raw)
To: linux-arm-kernel
On 10/16/2016 08:50 AM, Guenter Roeck wrote:
> On 10/16/2016 08:33 AM, Sylvain Rochet wrote:
>> Hi,
>>
>> On Wed, Oct 07, 2015 at 01:01:12PM +0200, Alexandre Belloni wrote:
>>> On 06/10/2015 at 22:28:45 +0200, Sylvain Rochet wrote :
>>>> Since turning on idle-halt in commit 5161b31dc39a (watchdog:
>>>> at91sam9_wdt: better watchdog support"), SoCs compatible with
>>>> at91sam9260-wdt not using a device tree no longer reboot if the watchdog
>>>> times out while the CPU is in idle state. Removing the
>>>> AT91_WDT_WDIDLEHLT flag that was set by default fixes this.
>>>>
>>>> Signed-off-by: Sylvain Rochet <sylvain.rochet@finsecur.com>
>>>> Fixes: 5161b31dc39a ("watchdog: at91sam9_wdt: better watchdog support")
>>>> Cc: <stable@vger.kernel.org> # 3.14+
>>>
>>> Acked-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
>>>
>>> However, we don't really care about that for kernels after 3.18 as no
>>> users are using pdata anymore.
>>> I think you could send a follow-up patch removing pdata support
>>> completely.
>>
>> Looks like this one falls through the cracks, it didn't reach mainline
>> and therefore wasn't applied to stable branches.
>>
> Possibly that happened because you did not copy the watchdog mailing list.
>
... and your other patches were not sent to the watchdog mailing list either,
so you should not expect them to be picked up either.
Seriously, how do you expect _any_ patch to be picked up if you neither copy
the subsystem mailing list nor the subsystem maintainer ?
Guenter
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH] watchdog: at91sam9: keep watchdog running in idle mode
2016-10-16 15:55 ` Guenter Roeck
@ 2016-10-16 20:39 ` Sylvain Rochet
0 siblings, 0 replies; 6+ messages in thread
From: Sylvain Rochet @ 2016-10-16 20:39 UTC (permalink / raw)
To: linux-arm-kernel
Hi Guenter,
On Sun, Oct 16, 2016 at 08:55:41AM -0700, Guenter Roeck wrote:
> On 10/16/2016 08:50 AM, Guenter Roeck wrote:
> > On 10/16/2016 08:33 AM, Sylvain Rochet wrote:
> > >
> > > Looks like this one falls through the cracks, it didn't reach mainline
> > > and therefore wasn't applied to stable branches.
> >
> > Possibly that happened because you did not copy the watchdog mailing list.
>
> ... and your other patches were not sent to the watchdog mailing list either,
> so you should not expect them to be picked up either.
>
> Seriously, how do you expect _any_ patch to be picked up if you neither copy
> the subsystem mailing list nor the subsystem maintainer ?
Whoops, thanks for the heads up, I wonder how I managed to mess up that
at that time, I usually take care of that. The other series need
respinning anyway so I can fix it for v2 (if any).
Cheers,
Sylvain
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-16 20:39 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-06 20:28 [PATCH] watchdog: at91sam9: keep watchdog running in idle mode Sylvain Rochet
2015-10-07 11:01 ` Alexandre Belloni
2016-10-16 15:33 ` Sylvain Rochet
2016-10-16 15:50 ` Guenter Roeck
2016-10-16 15:55 ` Guenter Roeck
2016-10-16 20:39 ` Sylvain Rochet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).