From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PM / OPP: fix debugfs files for 64-bit
Date: Wed, 7 Oct 2015 16:51:49 +0530 [thread overview]
Message-ID: <20151007112149.GB22530@linux> (raw)
In-Reply-To: <20151007110755.GA6601@kroah.com>
On 07-10-15, 12:07, Greg Kroah-Hartman wrote:
> Why would you be wanting to create a "unsigned long" as an api anyway?
> Just force it to be u64 all the time, can't you do that?
Okay, so the variable in question (lets say frequency) is an 'unsigned
long' and that's how all the APIs of clock framework expect/define
it.
And you are probably saying that we do this:
unsigned long freq;
debugfs_create_u64((u64 *)&freq);
Right? Or are you asking to update clock APIs to be converted to u64?
This will break things on a 32 bit architecture where unsigned long is
32 bits long, as doing this will overwrite the next 32 bits:
*freq = XYZ;
--
viresh
next prev parent reply other threads:[~2015-10-07 11:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 7:35 [PATCH] PM / OPP: fix debugfs files for 64-bit Arnd Bergmann
2015-10-07 10:59 ` Viresh Kumar
2015-10-07 11:03 ` Viresh Kumar
2015-10-07 11:07 ` Greg Kroah-Hartman
2015-10-07 11:21 ` Viresh Kumar [this message]
2015-10-07 12:57 ` Greg Kroah-Hartman
2015-10-07 13:03 ` Viresh Kumar
2015-10-07 17:19 ` Greg Kroah-Hartman
2015-10-07 17:27 ` Viresh Kumar
2015-10-07 17:39 ` Greg Kroah-Hartman
2015-10-07 18:00 ` Viresh Kumar
2015-10-07 19:12 ` Arnd Bergmann
2015-10-08 7:48 ` Viresh Kumar
2015-10-08 14:25 ` Alan Stern
2015-10-19 15:40 ` Michael Turquette
2015-10-19 15:53 ` Russell King - ARM Linux
2015-10-20 10:22 ` Michael Turquette
2015-10-07 16:33 ` Russell King - ARM Linux
2015-10-07 16:36 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151007112149.GB22530@linux \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).