linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM64: kernel: implement ACPI parking protocol
Date: Wed, 7 Oct 2015 14:03:47 +0100	[thread overview]
Message-ID: <20151007130347.GB875@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20151006173152.GA15091@red-moon>

On Tue, Oct 06, 2015 at 06:31:52PM +0100, Lorenzo Pieralisi wrote:
> On Tue, Oct 06, 2015 at 01:15:32PM -0400, Mark Salter wrote:
> > On Tue, 2015-10-06 at 17:50 +0100, Catalin Marinas wrote:
> > > Question to Lorenzo and Mark Salter: was this patch successfully tested
> > > on real hardware (like Applied X-Gene)?
> > 
> > It doesn't work on X-Gene/Mustang because the existing firmware
> > implementations are not exactly compliant with the parking protocol
> > spec. I've been hacking on the firmware trying to get something
> > which will work wrt the spec but keep getting distracted by other
> > things.
> 
> I tested the code on AMD Supercharger even though I had to change
> the remap implementation since the existing firmware uses cacheable
> mappings for the mailboxes.
> 
> I put it together to make sure that it is there if any platform
> compliant with it relies on it and more importantly to prevent
> non-compliant implentations from trickling into the kernel,
> basically to prevent broken firmware implementations from being
> considered compliant and "working".

That's a good point. However, AFAIK, AMD are using PSCI already in their
firmware implementation and that's what we recommend anyway if EL3 is
available.

So this patch is mainly aimed at X-Gene since other implementations I'm
aware of have EL3 already. What are the chances of Applied Micro fixing
their firmware and actually using this patch? (not a question for you;
I'm hoping some Applied engineers would comment).

-- 
Catalin

  reply	other threads:[~2015-10-07 13:03 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-10 17:40 [PATCH v2] ARM64: kernel: implement ACPI parking protocol Lorenzo Pieralisi
2015-09-11 13:30 ` Mark Salter
2015-09-11 14:35   ` Lorenzo Pieralisi
2015-10-06 16:50 ` Catalin Marinas
2015-10-06 17:15   ` Mark Salter
2015-10-06 17:31     ` Lorenzo Pieralisi
2015-10-07 13:03       ` Catalin Marinas [this message]
     [not found] <CAPw-ZTmsLqgh6W6R0uLgQjueV7XjaGOD49CYCRYufJ43zT8Kyg@mail.gmail.com>
2016-01-08 15:01 ` Lorenzo Pieralisi
2016-01-08 19:05   ` Loc Ho
2016-01-25 21:28     ` Loc Ho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151007130347.GB875@e104818-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).