From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mfd: remove unused variables
Date: Thu, 8 Oct 2015 08:23:04 +0100 [thread overview]
Message-ID: <20151008072304.GJ17172@x1> (raw)
In-Reply-To: <7700818.mjdn6x2kkK@wuerfel>
On Wed, 07 Oct 2015, Arnd Bergmann wrote:
> A mass-cleanup by Javier Martinez Canillas removed a lot of
> unused code, but left at least two variables in mfd drivers
> in place that are now causing warnings:
>
> drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
> drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
> drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
> drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
>
> This removes them as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
> Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
Where's your diffstat?
> ---
>
> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 193ecee1fa7e..5abcbb2e8849 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> struct lm3533 *lm3533;
> - int ret;
>
> dev_dbg(&i2c->dev, "%s\n", __func__);
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index b98cf1de0a55..d63f3a896adb 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
>
> static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
> {
> - int err;
> -
> rtsx_pci_init_cmd(pcr);
>
> while (*tbl & 0xFFFF0000) {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2015-10-08 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-07 12:49 [PATCH] mfd: remove unused variables Arnd Bergmann
2015-10-07 13:03 ` Javier Martinez Canillas
2015-10-08 7:23 ` Lee Jones [this message]
2015-10-08 7:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008072304.GJ17172@x1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).