* [PATCH] mfd: remove unused variables
@ 2015-10-07 12:49 Arnd Bergmann
2015-10-07 13:03 ` Javier Martinez Canillas
2015-10-08 7:23 ` Lee Jones
0 siblings, 2 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-10-07 12:49 UTC (permalink / raw)
To: linux-arm-kernel
A mass-cleanup by Javier Martinez Canillas removed a lot of
unused code, but left at least two variables in mfd drivers
in place that are now causing warnings:
drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
This removes them as well.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
---
diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
index 193ecee1fa7e..5abcbb2e8849 100644
--- a/drivers/mfd/lm3533-core.c
+++ b/drivers/mfd/lm3533-core.c
@@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
const struct i2c_device_id *id)
{
struct lm3533 *lm3533;
- int ret;
dev_dbg(&i2c->dev, "%s\n", __func__);
diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
index b98cf1de0a55..d63f3a896adb 100644
--- a/drivers/mfd/rtsx_pcr.c
+++ b/drivers/mfd/rtsx_pcr.c
@@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
{
- int err;
-
rtsx_pci_init_cmd(pcr);
while (*tbl & 0xFFFF0000) {
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] mfd: remove unused variables
2015-10-07 12:49 [PATCH] mfd: remove unused variables Arnd Bergmann
@ 2015-10-07 13:03 ` Javier Martinez Canillas
2015-10-08 7:23 ` Lee Jones
1 sibling, 0 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-10-07 13:03 UTC (permalink / raw)
To: linux-arm-kernel
Hello Arnd,
On 10/07/2015 02:49 PM, Arnd Bergmann wrote:
> A mass-cleanup by Javier Martinez Canillas removed a lot of
> unused code, but left at least two variables in mfd drivers
> in place that are now causing warnings:
>
> drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
> drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
> drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
> drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
>
> This removes them as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
> Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
> ---
I thought that I got rid of all the unused variables but somehow
I missed these. Sorry and thanks a lot for taking care of this.
>
> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 193ecee1fa7e..5abcbb2e8849 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> struct lm3533 *lm3533;
> - int ret;
>
> dev_dbg(&i2c->dev, "%s\n", __func__);
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index b98cf1de0a55..d63f3a896adb 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
>
> static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
> {
> - int err;
> -
> rtsx_pci_init_cmd(pcr);
>
> while (*tbl & 0xFFFF0000) {
>
Patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] mfd: remove unused variables
2015-10-07 12:49 [PATCH] mfd: remove unused variables Arnd Bergmann
2015-10-07 13:03 ` Javier Martinez Canillas
@ 2015-10-08 7:23 ` Lee Jones
2015-10-08 7:26 ` Lee Jones
1 sibling, 1 reply; 4+ messages in thread
From: Lee Jones @ 2015-10-08 7:23 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 07 Oct 2015, Arnd Bergmann wrote:
> A mass-cleanup by Javier Martinez Canillas removed a lot of
> unused code, but left at least two variables in mfd drivers
> in place that are now causing warnings:
>
> drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
> drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
> drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
> drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
>
> This removes them as well.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
> Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
Where's your diffstat?
> ---
>
> diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> index 193ecee1fa7e..5abcbb2e8849 100644
> --- a/drivers/mfd/lm3533-core.c
> +++ b/drivers/mfd/lm3533-core.c
> @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> const struct i2c_device_id *id)
> {
> struct lm3533 *lm3533;
> - int ret;
>
> dev_dbg(&i2c->dev, "%s\n", __func__);
>
> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index b98cf1de0a55..d63f3a896adb 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
>
> static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
> {
> - int err;
> -
> rtsx_pci_init_cmd(pcr);
>
> while (*tbl & 0xFFFF0000) {
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] mfd: remove unused variables
2015-10-08 7:23 ` Lee Jones
@ 2015-10-08 7:26 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2015-10-08 7:26 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, 08 Oct 2015, Lee Jones wrote:
> On Wed, 07 Oct 2015, Arnd Bergmann wrote:
>
> > A mass-cleanup by Javier Martinez Canillas removed a lot of
> > unused code, but left at least two variables in mfd drivers
> > in place that are now causing warnings:
> >
> > drivers/mfd/rtsx_pcr.c: In function 'rtsx_pci_set_pull_ctl':
> > drivers/mfd/rtsx_pcr.c:564:6: warning: unused variable 'err' [-Wunused-variable]
> > drivers/mfd/lm3533-core.c: In function 'lm3533_i2c_probe':
> > drivers/mfd/lm3533-core.c:595:6: warning: unused variable 'ret' [-Wunused-variable]
> >
> > This removes them as well.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: c749db571dc ("mfd: lm3533: Simplify function return logic")
> > Fixes: a3c29b09982 ("mfd: rtsx: Simplify function return logic")
>
> Where's your diffstat?
By the way, someone sent a patch to fix these 20 mins before you
did. :)
> > ---
> >
> > diff --git a/drivers/mfd/lm3533-core.c b/drivers/mfd/lm3533-core.c
> > index 193ecee1fa7e..5abcbb2e8849 100644
> > --- a/drivers/mfd/lm3533-core.c
> > +++ b/drivers/mfd/lm3533-core.c
> > @@ -592,7 +592,6 @@ static int lm3533_i2c_probe(struct i2c_client *i2c,
> > const struct i2c_device_id *id)
> > {
> > struct lm3533 *lm3533;
> > - int ret;
> >
> > dev_dbg(&i2c->dev, "%s\n", __func__);
> >
> > diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> > index b98cf1de0a55..d63f3a896adb 100644
> > --- a/drivers/mfd/rtsx_pcr.c
> > +++ b/drivers/mfd/rtsx_pcr.c
> > @@ -561,8 +561,6 @@ EXPORT_SYMBOL_GPL(rtsx_pci_write_ppbuf);
> >
> > static int rtsx_pci_set_pull_ctl(struct rtsx_pcr *pcr, const u32 *tbl)
> > {
> > - int err;
> > -
> > rtsx_pci_init_cmd(pcr);
> >
> > while (*tbl & 0xFFFF0000) {
> >
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-08 7:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-07 12:49 [PATCH] mfd: remove unused variables Arnd Bergmann
2015-10-07 13:03 ` Javier Martinez Canillas
2015-10-08 7:23 ` Lee Jones
2015-10-08 7:26 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).