From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] clk: qcom: Drop calls to qcom_cc_remove()
Date: Thu, 8 Oct 2015 11:09:36 -0700 [thread overview]
Message-ID: <20151008180936.GG26883@codeaurora.org> (raw)
In-Reply-To: <56163F97.1060604@codeaurora.org>
On 10/08, Rajendra Nayak wrote:
> On 10/08/2015 12:47 PM, Stephen Boyd wrote:
> > Now that qcom_cc_remove() is a nop, drop calls to
> > qcom_cc_remove() and any empty driver remove functions.
> >
> > Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
> > ---
> >
> > And here's the driver part. I left 8960_remove in place to make your patch
> > easier to apply. Time to sleep.
>
> I was trying to test this out, but looks like none of our clock drivers
> support a clean remove and reprobe (with or without this patch)
>
> The problem seems to be the fixed rate clocks that get registered at probe,
> never unregistered, causing the subsequent probe to fail.
Yeah the gcc drivers are not so good there. We should probably fix those too.
The mmcc drivers support a clean remove and reprobe though. So I
tested it on msm8960 with these patches and everything looks
good. Removing gcc is sort of annoying because it provides the
clock for the serial console.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-10-08 18:09 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 5:00 [PATCH v3 0/9] qcom: Add support for TSENS driver Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 1/9] thermal: qcom: tsens: Add a skeletal TSENS drivers Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 2/9] thermal: qcom: tsens-8916: Add support for 8916 family of SoCs Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 3/9] thermal: qcom: tsens-8974: Add support for 8974 " Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 4/9] clk: qcom: create virtual child device for TSENS Rajendra Nayak
2015-10-08 6:05 ` Stephen Boyd
2015-10-08 7:03 ` Stephen Boyd
2015-10-08 7:17 ` [PATCH] clk: qcom: Drop calls to qcom_cc_remove() Stephen Boyd
2015-10-08 10:04 ` Rajendra Nayak
2015-10-08 18:09 ` Stephen Boyd [this message]
2015-10-08 7:13 ` [PATCH v3 4/9] clk: qcom: create virtual child device for TSENS Rajendra Nayak
2015-10-08 23:21 ` Stephen Boyd
2015-10-09 3:14 ` Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 5/9] thermal: qcom: tsens-8960: Add support for 8960 family of SoCs Rajendra Nayak
2015-10-08 6:12 ` Stephen Boyd
2015-10-08 7:15 ` Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 6/9] arm: dts: msm8974: Add thermal zones, tsens and qfprom nodes Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 7/9] arm: dts: apq8064: " Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 8/9] arm: dts: apq8084: " Rajendra Nayak
2015-10-08 5:01 ` [PATCH v3 9/9] arm64: dts: msm8916: " Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151008180936.GG26883@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).