From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP2+: Fixed inverted OMAP_OFFOUT_EN
Date: Thu, 8 Oct 2015 23:40:06 -0700 [thread overview]
Message-ID: <20151009064005.GA23801@atomide.com> (raw)
In-Reply-To: <1444308486-16204-1-git-send-email-benjamint@bsquare.com>
* Ben Tucker <benjamint@bsquare.com> [151008 06:09]:
> The OFFOUTENABLE bit of the omap PADCONF registers is active low.
> The mux code assumed that it was active high and this patch fixes this
> problem.
>
> Tested on an AM37x device.
Hmm what are the test cases you're using to validate this so
I can try to reproduce?
AFAIK because of erratum 1.158 for GPIO pins needing to be
muxed temporarly for input + pull + safe mode for off mode,
so I'm wondering in which cases the OFFOUTENABLE can be used.
I have a patch in works for 1.158 using gpio-ranges, and the
test case I'm using is the reset of WLAN that happens in off
mode as the enable GPIO glitches when returning from off mode.
Also.. I'm wondring why this has not been caught earlier?
Maybe because 1.158 is needed on omap3?
Regrds,
Tony
next parent reply other threads:[~2015-10-09 6:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1444308486-16204-1-git-send-email-benjamint@bsquare.com>
2015-10-09 6:40 ` Tony Lindgren [this message]
2015-10-08 16:19 [PATCH] ARM: OMAP2+: Fixed inverted OMAP_OFFOUT_EN Ben Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151009064005.GA23801@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).