* [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
@ 2015-10-12 1:17 Wenyou Yang
2015-10-12 6:53 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Wenyou Yang @ 2015-10-12 1:17 UTC (permalink / raw)
To: linux-arm-kernel
This patch is to clear the RTC alarm status flag prior to suspending
to avoid the erroneous wake-up activity.
Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---
drivers/rtc/rtc-at91rm9200.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
index cb62e21..b60fd47 100644
--- a/drivers/rtc/rtc-at91rm9200.c
+++ b/drivers/rtc/rtc-at91rm9200.c
@@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
/* this IRQ is shared with DBGU and other hardware which isn't
* necessarily doing PM like we are...
*/
+ at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
+
at91_rtc_imr = at91_rtc_read_imr()
& (AT91_RTC_ALARM|AT91_RTC_SECEV);
if (at91_rtc_imr) {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
2015-10-12 1:17 [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Wenyou Yang
@ 2015-10-12 6:53 ` Alexandre Belloni
2015-10-12 7:48 ` Yang, Wenyou
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2015-10-12 6:53 UTC (permalink / raw)
To: linux-arm-kernel
Hi Wenyou,
On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity.
>
Is this a new issue appearing with the sama5d2 or was it present from
the beginning?
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> drivers/rtc/rtc-at91rm9200.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index cb62e21..b60fd47 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
> /* this IRQ is shared with DBGU and other hardware which isn't
> * necessarily doing PM like we are...
> */
> + at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> +
> at91_rtc_imr = at91_rtc_read_imr()
> & (AT91_RTC_ALARM|AT91_RTC_SECEV);
> if (at91_rtc_imr) {
> --
> 1.7.9.5
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
2015-10-12 6:53 ` Alexandre Belloni
@ 2015-10-12 7:48 ` Yang, Wenyou
2015-10-12 7:51 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Yang, Wenyou @ 2015-10-12 7:48 UTC (permalink / raw)
To: linux-arm-kernel
Hi Alexandre,
> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com]
> Sent: 2015?10?12? 14:53
> To: Yang, Wenyou
> Cc: Alessandro Zummo; Ferre, Nicolas; Desroches, Ludovic; rtc-
> linux at googlegroups.com; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to
> suspending
>
> Hi Wenyou,
>
> On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> > This patch is to clear the RTC alarm status flag prior to suspending
> > to avoid the erroneous wake-up activity.
> >
>
> Is this a new issue appearing with the sama5d2 or was it present from the
> beginning?
With the sama5d2 ULP1 mode, not from the beginning.
>
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> > drivers/rtc/rtc-at91rm9200.c | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/rtc/rtc-at91rm9200.c
> > b/drivers/rtc/rtc-at91rm9200.c index cb62e21..b60fd47 100644
> > --- a/drivers/rtc/rtc-at91rm9200.c
> > +++ b/drivers/rtc/rtc-at91rm9200.c
> > @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
> > /* this IRQ is shared with DBGU and other hardware which isn't
> > * necessarily doing PM like we are...
> > */
> > + at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> > +
> > at91_rtc_imr = at91_rtc_read_imr()
> > & (AT91_RTC_ALARM|AT91_RTC_SECEV);
> > if (at91_rtc_imr) {
> > --
> > 1.7.9.5
> >
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
Best Regards,
Wenyou Yang
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
2015-10-12 7:48 ` Yang, Wenyou
@ 2015-10-12 7:51 ` Alexandre Belloni
2015-10-12 7:55 ` Yang, Wenyou
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2015-10-12 7:51 UTC (permalink / raw)
To: linux-arm-kernel
On 12/10/2015 at 07:48:18 +0000, Yang, Wenyou wrote :
> > On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> > > This patch is to clear the RTC alarm status flag prior to suspending
> > > to avoid the erroneous wake-up activity.
> > >
> >
> > Is this a new issue appearing with the sama5d2 or was it present from the
> > beginning?
> With the sama5d2 ULP1 mode, not from the beginning.
>
I think this information should appear in the commit log.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending
2015-10-12 7:51 ` Alexandre Belloni
@ 2015-10-12 7:55 ` Yang, Wenyou
0 siblings, 0 replies; 5+ messages in thread
From: Yang, Wenyou @ 2015-10-12 7:55 UTC (permalink / raw)
To: linux-arm-kernel
> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni at free-electrons.com]
> Sent: 2015?10?12? 15:51
> To: Yang, Wenyou
> Cc: Alessandro Zummo; Ferre, Nicolas; Desroches, Ludovic; rtc-
> linux at googlegroups.com; linux-kernel at vger.kernel.org; linux-arm-
> kernel at lists.infradead.org
> Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to
> suspending
>
> On 12/10/2015 at 07:48:18 +0000, Yang, Wenyou wrote :
> > > On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> > > > This patch is to clear the RTC alarm status flag prior to
> > > > suspending to avoid the erroneous wake-up activity.
> > > >
> > >
> > > Is this a new issue appearing with the sama5d2 or was it present
> > > from the beginning?
> > With the sama5d2 ULP1 mode, not from the beginning.
> >
>
> I think this information should appear in the commit log.
I will add it in the next version, thanks.
>
> --
> Alexandre Belloni, Free Electrons
> Embedded Linux, Kernel and Android engineering http://free-electrons.com
Best Regards,
Wenyou Yang
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-12 7:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 1:17 [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending Wenyou Yang
2015-10-12 6:53 ` Alexandre Belloni
2015-10-12 7:48 ` Yang, Wenyou
2015-10-12 7:51 ` Alexandre Belloni
2015-10-12 7:55 ` Yang, Wenyou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).