From: sylvain.rochet@finsecur.com (Sylvain Rochet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/6] watchdog: at91sam9: rename heartbeats into timeout where necessary
Date: Mon, 12 Oct 2015 12:07:06 +0200 [thread overview]
Message-ID: <20151012100706.GA3088@gradator.net> (raw)
In-Reply-To: <1444340074-15437-4-git-send-email-sylvain.rochet@finsecur.com>
On Thu, Oct 08, 2015 at 11:34:31PM +0200, Sylvain Rochet wrote:
>
> @@ -344,7 +342,7 @@ static int __init at91wdt_probe(struct platform_device *pdev)
> wdt->wdd.parent = &pdev->dev;
> wdt->wdd.info = &at91_wdt_info;
> wdt->wdd.ops = &at91_wdt_ops;
> - wdt->wdd.timeout = WDT_HEARTBEAT;
> + wdt->wdd.timeout = wdt_timeout;
This wasn't a good idea, if wdt_timeout is set using a module parameter
to a wrong value we end up using this wrong value. Setting the default
to a valid hardwired value and checking if the proposed value is valid
using watchdog_init_timeout is obviously the way to go. I will rework
that in v2.
Sylvain
next prev parent reply other threads:[~2015-10-12 10:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 21:34 [PATCH 0/6] watchdog: sama5d4 and at91sam9: trivial rework Sylvain Rochet
2015-10-08 21:34 ` [PATCH 1/6] watchdog: at91sam9: use devm_request_irq instead of request_irq Sylvain Rochet
2015-10-08 21:34 ` [PATCH 2/6] watchdog: at91sam9: use watchdog_get_drvdata instead of container_of Sylvain Rochet
2015-10-08 21:34 ` [PATCH 3/6] watchdog: at91sam9: rename heartbeats into timeout where necessary Sylvain Rochet
2015-10-12 10:07 ` Sylvain Rochet [this message]
2015-10-08 21:34 ` [PATCH 4/6] watchdog: at91sam9: remove nowayout useless copy Sylvain Rochet
2015-10-08 21:34 ` [PATCH 5/6] watchdog: at91sam9: remove unused pdata support Sylvain Rochet
2015-10-08 21:34 ` [PATCH 6/6] watchdog: sama5d4: try to set timeout from device tree first Sylvain Rochet
2015-10-12 7:50 ` Alexandre Belloni
2015-10-12 8:12 ` Yang, Wenyou
2015-10-12 13:56 ` Sylvain Rochet
2015-10-12 9:09 ` Sylvain Rochet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012100706.GA3088@gradator.net \
--to=sylvain.rochet@finsecur.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).