Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: broonie@kernel.org (Mark Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] regulator: core: avoid unused variable warning
Date: Mon, 12 Oct 2015 16:42:31 +0100	[thread overview]
Message-ID: <20151012154231.GE4238@sirena.org.uk> (raw)
In-Reply-To: <5130320.kXvB35QoYU@wuerfel>

On Fri, Oct 09, 2015 at 02:36:47PM +0200, Arnd Bergmann wrote:

> The second argument of the mutex_lock_nested() helper is only
> evaluated if CONFIG_DEBUG_LOCK_ALLOC is set. Otherwise we
> get this build warning for the new regulator_lock_supply
> function:

Shouldn't we have an annotation or something for this in
mutex_lock_nested()?  It seems like something that might come up
elsewhere and it's a bit of a surprise to have one of the arguments
there not be evaluated.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20151012/7f04d4b2/attachment.sig>

  reply	other threads:[~2015-10-12 15:42 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-09 12:36 [PATCH] regulator: core: avoid unused variable warning Arnd Bergmann
2015-10-12 15:42 ` Mark Brown [this message]
2015-10-13 19:28   ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151012154231.GE4238@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox