From: sam@ravnborg.org (Sam Ravnborg)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC] arm: add __initbss section attribute
Date: Mon, 12 Oct 2015 22:04:23 +0200 [thread overview]
Message-ID: <20151012200422.GA29175@ravnborg.org> (raw)
In-Reply-To: <1444622356-8263-1-git-send-email-yalin.wang2010@gmail.com>
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
>
> -#define BSS_SECTION(sbss_align, bss_align, stop_align) \
> +#define BSS_SECTION(sbss_align, bss_align, initbss_align, stop_align) \
A few comments:
1) - please align the backslash at the end of the
line with the backslash above it.
2) - you need to fix all the remaining users of BSS_SECTION.
3) - do we really need the flexibility to specify an alignment (stop_align)?
If not - drop the extra argument.
Sam
next prev parent reply other threads:[~2015-10-12 20:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 3:59 [RFC] arm: add __initbss section attribute yalin wang
2015-10-12 8:22 ` Ard Biesheuvel
2015-10-12 8:46 ` yalin wang
2015-10-12 10:21 ` Arnd Bergmann
2015-10-12 20:04 ` Sam Ravnborg [this message]
[not found] ` <FEDC4251-5A6A-4E3C-AE36-8E5B55D9D6CF@gmail.com>
2015-10-13 9:40 ` Arnd Bergmann
2015-10-13 9:51 ` yalin wang
2015-10-13 11:28 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012200422.GA29175@ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).