From: computersforpeace@gmail.com (Brian Norris)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] mtd: nand: pass page number to ecc->write_xxx() methods
Date: Mon, 12 Oct 2015 16:35:37 -0700 [thread overview]
Message-ID: <20151012233537.GR107187@google.com> (raw)
In-Reply-To: <1443765205-8730-1-git-send-email-boris.brezillon@free-electrons.com>
On Fri, Oct 02, 2015 at 07:53:25AM +0200, Boris Brezillon wrote:
> The ->read_xxx() methods are all passed the page number the NAND controller
> is supposed to read, but ->write_xxx() do not have such a parameter.
>
> This is a problem if we want to properly implement data
> scrambling/randomization in order to mitigate MLC sensibility to repeated
> pattern: to prevent bitflips in adjacent pages in the same block we need
> to avoid repeating the same pattern at the same offset in those pages,
> hence the randomizer/scrambler engine need to be passed the page value
> in order to adapt its seed accordingly.
>
> Moreover, adding the page parameter to the ->write_xxx() methods add some
> consistency to the current API.
>
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> CC: Josh Wu <josh.wu@atmel.com>
> CC: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> CC: Maxime Ripard <maxime.ripard@free-electrons.com>
> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> CC: Huang Shijie <shijie.huang@arm.com>
> CC: Stefan Agner <stefan@agner.ch>
> CC: devel at driverdev.osuosl.org
> CC: linux-arm-kernel at lists.infradead.org
> CC: linux-kernel at vger.kernel.org
> ---
> Changes since v2:
> - fixed compilation error in the gpmi driver
> - compile tested all impacted drivers except the bf5xx_nand,
> fsl_elbc_nand and fsl_ifc_nand ones
>
> Changes since v1:
> - rebased on l2-mtd/master
> - fixed compilation error in the docg4 driver
> ---
> drivers/mtd/nand/atmel_nand.c | 6 ++++--
> drivers/mtd/nand/bf5xx_nand.c | 3 ++-
> drivers/mtd/nand/brcmnand/brcmnand.c | 4 ++--
> drivers/mtd/nand/cafe_nand.c | 3 ++-
> drivers/mtd/nand/denali.c | 5 +++--
> drivers/mtd/nand/docg4.c | 6 +++---
> drivers/mtd/nand/fsl_elbc_nand.c | 4 ++--
> drivers/mtd/nand/fsl_ifc_nand.c | 2 +-
> drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 8 +++----
> drivers/mtd/nand/hisi504_nand.c | 3 ++-
> drivers/mtd/nand/lpc32xx_mlc.c | 3 ++-
> drivers/mtd/nand/lpc32xx_slc.c | 5 +++--
> drivers/mtd/nand/nand_base.c | 31 ++++++++++++++++++---------
> drivers/mtd/nand/omap2.c | 3 ++-
> drivers/mtd/nand/pxa3xx_nand.c | 3 ++-
> drivers/mtd/nand/sh_flctl.c | 3 ++-
> drivers/mtd/nand/sunxi_nand.c | 5 +++--
> drivers/mtd/nand/vf610_nfc.c | 2 +-
> drivers/staging/mt29f_spinand/mt29f_spinand.c | 3 ++-
> include/linux/mtd/nand.h | 6 +++---
> 20 files changed, 66 insertions(+), 42 deletions(-)
Hmm, am I missing something, or does this not apply to l2-mtd.git or
linux-next.git?
next prev parent reply other threads:[~2015-10-12 23:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 5:53 [PATCH v3] mtd: nand: pass page number to ecc->write_xxx() methods Boris Brezillon
2015-10-12 23:35 ` Brian Norris [this message]
2015-10-13 7:28 ` Boris Brezillon
2015-10-13 9:22 ` [PATCH v4] " Boris Brezillon
2015-10-13 18:06 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151012233537.GR107187@google.com \
--to=computersforpeace@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).