* [PATCH v2 1/3] arm:exynos: IRQCHIP_DECLARE macro is now accessible
2015-10-13 12:56 [PATCH v2 0/3] arm:irchip: IRQCHIP_DECLARE macro is now accessible Joel Porquet
@ 2015-10-13 12:56 ` Joel Porquet
2015-10-13 12:56 ` [PATCH v2 2/3] arm:imx: " Joel Porquet
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Joel Porquet @ 2015-10-13 12:56 UTC (permalink / raw)
To: linux-arm-kernel
The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h', making it
globally accessible.
See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d ("irqchip: Move
IRQCHIP_DECLARE macro to include/linux/irqchip.h").
This patch adds the inclusion of 'include/linux/irqchip.h' and replaces the
use of OF_DECLARE_2 with IRQCHIP_DECLARE.
Signed-off-by: Joel Porquet <joel@porquet.org>
---
arch/arm/mach-exynos/suspend.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-exynos/suspend.c b/arch/arm/mach-exynos/suspend.c
index e00eb39..dfb1fcf 100644
--- a/arch/arm/mach-exynos/suspend.c
+++ b/arch/arm/mach-exynos/suspend.c
@@ -19,6 +19,7 @@
#include <linux/cpu_pm.h>
#include <linux/io.h>
#include <linux/irq.h>
+#include <linux/irqchip.h>
#include <linux/irqdomain.h>
#include <linux/of_address.h>
#include <linux/err.h>
@@ -262,7 +263,7 @@ static int __init exynos_pmu_irq_init(struct device_node *node,
return 0;
}
-#define EXYNOS_PMU_IRQ(symbol, name) OF_DECLARE_2(irqchip, symbol, name, exynos_pmu_irq_init)
+#define EXYNOS_PMU_IRQ(symbol, name) IRQCHIP_DECLARE(symbol, name, exynos_pmu_irq_init)
EXYNOS_PMU_IRQ(exynos3250_pmu_irq, "samsung,exynos3250-pmu");
EXYNOS_PMU_IRQ(exynos4210_pmu_irq, "samsung,exynos4210-pmu");
--
2.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 2/3] arm:imx: IRQCHIP_DECLARE macro is now accessible
2015-10-13 12:56 [PATCH v2 0/3] arm:irchip: IRQCHIP_DECLARE macro is now accessible Joel Porquet
2015-10-13 12:56 ` [PATCH v2 1/3] arm:exynos: " Joel Porquet
@ 2015-10-13 12:56 ` Joel Porquet
2015-10-13 12:56 ` [PATCH v2 3/3] arm:omap2: " Joel Porquet
2015-10-13 13:48 ` [PATCH v2 0/3] arm:irchip: " Shawn Guo
3 siblings, 0 replies; 5+ messages in thread
From: Joel Porquet @ 2015-10-13 12:56 UTC (permalink / raw)
To: linux-arm-kernel
The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h', making it
globally accessible.
See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d ("irqchip: Move
IRQCHIP_DECLARE macro to include/linux/irqchip.h").
This patch adds the inclusion of 'include/linux/irqchip.h' and replaces the
use of OF_DECLARE_2 with IRQCHIP_DECLARE.
Signed-off-by: Joel Porquet <joel@porquet.org>
---
arch/arm/mach-imx/gpc.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-imx/gpc.c b/arch/arm/mach-imx/gpc.c
index 8c4467f..c7de608 100644
--- a/arch/arm/mach-imx/gpc.c
+++ b/arch/arm/mach-imx/gpc.c
@@ -14,6 +14,7 @@
#include <linux/delay.h>
#include <linux/io.h>
#include <linux/irq.h>
+#include <linux/irqchip.h>
#include <linux/of.h>
#include <linux/of_address.h>
#include <linux/of_irq.h>
@@ -269,11 +270,7 @@ static int __init imx_gpc_init(struct device_node *node,
return 0;
}
-/*
- * We cannot use the IRQCHIP_DECLARE macro that lives in
- * drivers/irqchip, so we're forced to roll our own. Not very nice.
- */
-OF_DECLARE_2(irqchip, imx_gpc, "fsl,imx6q-gpc", imx_gpc_init);
+IRQCHIP_DECLARE(imx_gpc, "fsl,imx6q-gpc", imx_gpc_init);
void __init imx_gpc_check_dt(void)
{
--
2.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 3/3] arm:omap2: IRQCHIP_DECLARE macro is now accessible
2015-10-13 12:56 [PATCH v2 0/3] arm:irchip: IRQCHIP_DECLARE macro is now accessible Joel Porquet
2015-10-13 12:56 ` [PATCH v2 1/3] arm:exynos: " Joel Porquet
2015-10-13 12:56 ` [PATCH v2 2/3] arm:imx: " Joel Porquet
@ 2015-10-13 12:56 ` Joel Porquet
2015-10-13 13:48 ` [PATCH v2 0/3] arm:irchip: " Shawn Guo
3 siblings, 0 replies; 5+ messages in thread
From: Joel Porquet @ 2015-10-13 12:56 UTC (permalink / raw)
To: linux-arm-kernel
The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h', making it
globally accessible.
See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d ("irqchip: Move
IRQCHIP_DECLARE macro to include/linux/irqchip.h").
This patch adds the inclusion of 'include/linux/irqchip.h' and replaces the
use of OF_DECLARE_2 with IRQCHIP_DECLARE.
Signed-off-by: Joel Porquet <joel@porquet.org>
---
arch/arm/mach-omap2/omap-wakeupgen.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-wakeupgen.c b/arch/arm/mach-omap2/omap-wakeupgen.c
index e1d2e99..a2dc324 100644
--- a/arch/arm/mach-omap2/omap-wakeupgen.c
+++ b/arch/arm/mach-omap2/omap-wakeupgen.c
@@ -20,6 +20,7 @@
#include <linux/init.h>
#include <linux/io.h>
#include <linux/irq.h>
+#include <linux/irqchip.h>
#include <linux/irqdomain.h>
#include <linux/of_address.h>
#include <linux/platform_device.h>
@@ -538,8 +539,4 @@ static int __init wakeupgen_init(struct device_node *node,
return 0;
}
-/*
- * We cannot use the IRQCHIP_DECLARE macro that lives in
- * drivers/irqchip, so we're forced to roll our own. Not very nice.
- */
-OF_DECLARE_2(irqchip, ti_wakeupgen, "ti,omap4-wugen-mpu", wakeupgen_init);
+IRQCHIP_DECLARE(ti_wakeupgen, "ti,omap4-wugen-mpu", wakeupgen_init);
--
2.6.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH v2 0/3] arm:irchip: IRQCHIP_DECLARE macro is now accessible
2015-10-13 12:56 [PATCH v2 0/3] arm:irchip: IRQCHIP_DECLARE macro is now accessible Joel Porquet
` (2 preceding siblings ...)
2015-10-13 12:56 ` [PATCH v2 3/3] arm:omap2: " Joel Porquet
@ 2015-10-13 13:48 ` Shawn Guo
3 siblings, 0 replies; 5+ messages in thread
From: Shawn Guo @ 2015-10-13 13:48 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Oct 13, 2015 at 02:56:12PM +0200, Joel Porquet wrote:
> The IRQCHIP_DECLARE macro migrated to 'include/linux/irqchip.h', making it
> globally accessible.
>
> See commit 91e20b5040c67c51aad88cf87db4305c5bd7f79d ("irqchip: Move
> IRQCHIP_DECLARE macro to include/linux/irqchip.h").
>
> This series of patches add inclusions of 'include/linux/irqchip.h' and
> replaces uses of macro OF_DECLARE_2 with IRQCHIP_DECLARE for platforms
> exynos, imx and omap2.
>
> I had submitted a single patch a few months ago
> (https://lkml.org/lkml/2015/7/7/1069), but it never got merged although it
> had been acked by all the subsystem maintainers. Hopefully, splitting the
> patch into these independent patches that can be applied separately should
> help.
>
> Jo?l
>
> Joel Porquet (3):
> arm:exynos: IRQCHIP_DECLARE macro is now accessible
> arm:imx: IRQCHIP_DECLARE macro is now accessible
> arm:omap2: IRQCHIP_DECLARE macro is now accessible
>
> arch/arm/mach-exynos/suspend.c | 3 ++-
> arch/arm/mach-imx/gpc.c | 7 ++-----
> arch/arm/mach-omap2/omap-wakeupgen.c | 7 ++-----
> 3 files changed, 6 insertions(+), 11 deletions(-)
Marc sent a patch [1] doing the same thing a few days ago.
Shawn
[1] http://thread.gmane.org/gmane.linux.ports.arm.kernel/444136
^ permalink raw reply [flat|nested] 5+ messages in thread