From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key,wakeup with wakeup-source property
Date: Tue, 13 Oct 2015 20:38:41 +0530 [thread overview]
Message-ID: <20151013150841.GZ5386@linux> (raw)
In-Reply-To: <1444747133-22671-1-git-send-email-sudeep.holla@arm.com>
On 13-10-15, 15:38, Sudeep Holla wrote:
> Keyboard driver for GPIO buttons(gpio-keys) checks for the legacy
> "gpio-key,wakeup" boolean property to enable gpio buttons as wakeup
> source.
>
> Few dts files assign value "1" to gpio-key,wakeup and in one instance a
> value "0" is assigned probably assuming it won't be enabled as a wakeup
> source. Since the presence of the boolean property indicates it is
> enabled, value of "0" have no value.
>
> This patch replaces the legacy "gpio-key,wakeup" with the unified
> "wakeup-source" property which inturn fixes the above mentioned issue.
>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: linux-rockchip at lists.infradead.org
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> arch/arm/boot/dts/spear1310-evb.dts | 2 +-
> arch/arm/boot/dts/spear1340-evb.dts | 2 +-
> arch/arm/boot/dts/spear320-hmi.dts | 4 ++--
Reviewed-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
next prev parent reply other threads:[~2015-10-13 15:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 13:32 [PATCH 1/2] ARM: dts: fix gpio-keys wakeup-source property Sudeep Holla
2015-10-13 13:32 ` [PATCH 2/2] ARM: dts: change gpio-key,wakeup property to boolean Sudeep Holla
2015-10-13 14:07 ` Rob Herring
2015-10-13 14:26 ` Sudeep Holla
2015-10-13 14:38 ` [PATCH 2/2][UPDATE] ARM: dts: replace gpio-key, wakeup with wakeup-source property Sudeep Holla
2015-10-13 15:08 ` Viresh Kumar [this message]
2015-10-13 17:52 ` Heiko Stübner
2015-10-14 0:13 ` [PATCH 1/2] ARM: dts: fix gpio-keys " Simon Horman
2015-10-14 9:01 ` Sudeep Holla
2015-10-14 15:27 ` Sudeep Holla
2015-10-15 14:57 ` Linus Walleij
2015-10-15 15:21 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013150841.GZ5386@linux \
--to=viresh.kumar@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).