From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] iommu/arm-smmu: Add support for MSI on SMMUv3
Date: Tue, 13 Oct 2015 19:48:29 +0100 [thread overview]
Message-ID: <20151013184829.GH24353@leverpostej> (raw)
In-Reply-To: <1444757550-24702-1-git-send-email-marc.zyngier@arm.com>
> +++ b/Documentation/devicetree/bindings/iommu/arm,smmu-v3.txt
> @@ -36,5 +36,25 @@ the PCIe specification.
> NOTE: this only applies to the SMMU itself, not
> masters connected upstream of the SMMU.
>
> +- msi-parent : phandles (and potential Device IDs) of MSI controllers
For correct terminology, I'd prefer to replace this line with:
- msi-parent: a list of phandle + msi-specifier pairs for MSI controllers
An msi-specifier may be zero cells, per
Documentation/devicetree/bindings/interrupt-controller/msi.txt, much
like other *-specifiers.
> + the SMMU can send MSIs to (instead of wired interrupts).
> + See devicetree/bindings.interrupt-controller/msi.txt
> + for a description of the msi-parent property.
The rest of this is fine, modulo the '.' which should be a '/'. in the
path.
With those changes:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks,
Mark.
prev parent reply other threads:[~2015-10-13 18:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 17:32 [PATCH v4] iommu/arm-smmu: Add support for MSI on SMMUv3 Marc Zyngier
2015-10-13 18:48 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151013184829.GH24353@leverpostej \
--to=mark.rutland@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox