linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.trumtrar@pengutronix.de (Steffen Trumtrar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: socfpga: dts: add fpga manager
Date: Tue, 13 Oct 2015 20:57:50 +0200	[thread overview]
Message-ID: <20151013185750.GB17155@pengutronix.de> (raw)
In-Reply-To: <1444760900-1373-1-git-send-email-atull@opensource.altera.com>

Hi Alan!

On Tue, Oct 13, 2015 at 01:28:20PM -0500, atull at opensource.altera.com wrote:
> From: Alan Tull <atull@opensource.altera.com>
> 
> Add FPGA manager to device tree for SoCFPGA.
> 
> Signed-off-by: Alan Tull <atull@opensource.altera.com>
> ---
>  arch/arm/boot/dts/socfpga.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi
> index 314e589..e37ba11 100644
> --- a/arch/arm/boot/dts/socfpga.dtsi
> +++ b/arch/arm/boot/dts/socfpga.dtsi
> @@ -834,5 +834,12 @@
>  			compatible = "altr,sys-mgr", "syscon";
>  			reg = <0xffd08000 0x4000>;
>  		};
> +
> +		hps_0_fpgamgr: fpgamgr at 0xff706000 {
> +			compatible = "altr,socfpga-fpga-mgr";
> +			reg = <0xFF706000 0x1000
> +			       0xFFB90000 0x1000>;
> +			interrupts = <0 175 4>;
> +		};
>  	};
>  };

Please keep the format in line with the rest of the file:
Hexvalues are lowercase and no 0x after the "fpgamgr@".
I'd say "And please put the node in its proper position
according to its address", but I see just now, that the
dtsi is all messed up right now anyway :-(

Regards,
Steffen

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2015-10-13 18:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13 18:28 [PATCH] ARM: socfpga: dts: add fpga manager atull at opensource.altera.com
2015-10-13 18:57 ` Steffen Trumtrar [this message]
2015-10-13 19:18   ` Dinh Nguyen
2015-10-13 19:46     ` atull
2015-10-13 20:27       ` Steffen Trumtrar
2015-10-13 20:20     ` Steffen Trumtrar
2015-10-13 18:58 ` Moritz Fischer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151013185750.GB17155@pengutronix.de \
    --to=s.trumtrar@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).