* [PATCH] firmware: qcom-scm: build for correct architecture level
@ 2015-10-12 14:56 Arnd Bergmann
2015-10-13 19:49 ` Andy Gross
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-10-12 14:56 UTC (permalink / raw)
To: linux-arm-kernel
The ".arch_extension sec" directive is only available on ARMv6 or higher,
so if we enable the SCM driver while building a kernel for an older CPU,
we get a build error:
/tmp/ccUyhMOY.s:130: Error: selected processor does not support ARM mode `smc #0'
/tmp/ccUyhMOY.s:216: Error: selected processor does not support ARM mode `smc #0'
/tmp/ccUyhMOY.s:373: Error: selected processor does not support ARM mode `smc #0'
make[4]: *** [drivers/firmware/qcom_scm-32.o] Error 1
This changes the Makefile so we pass the ARMv7 architecture level both
for the check and for the actual compilation of the scm driver.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
diff --git a/drivers/firmware/Makefile b/drivers/firmware/Makefile
index 2ee83474a3c1..f0066373b170 100644
--- a/drivers/firmware/Makefile
+++ b/drivers/firmware/Makefile
@@ -15,7 +15,7 @@ obj-$(CONFIG_FIRMWARE_MEMMAP) += memmap.o
obj-$(CONFIG_QCOM_SCM) += qcom_scm.o
obj-$(CONFIG_QCOM_SCM_64) += qcom_scm-64.o
obj-$(CONFIG_QCOM_SCM_32) += qcom_scm-32.o
-CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch_extension sec,-DREQUIRES_SEC=1)
+CFLAGS_qcom_scm-32.o :=$(call as-instr,.arch armv7-a\n.arch_extension sec,-DREQUIRES_SEC=1) -march=armv7-a
obj-y += broadcom/
obj-$(CONFIG_GOOGLE_FIRMWARE) += google/
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] firmware: qcom-scm: build for correct architecture level
2015-10-12 14:56 [PATCH] firmware: qcom-scm: build for correct architecture level Arnd Bergmann
@ 2015-10-13 19:49 ` Andy Gross
0 siblings, 0 replies; 2+ messages in thread
From: Andy Gross @ 2015-10-13 19:49 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Oct 12, 2015 at 04:56:19PM +0200, Arnd Bergmann wrote:
> The ".arch_extension sec" directive is only available on ARMv6 or higher,
> so if we enable the SCM driver while building a kernel for an older CPU,
> we get a build error:
>
> /tmp/ccUyhMOY.s:130: Error: selected processor does not support ARM mode `smc #0'
> /tmp/ccUyhMOY.s:216: Error: selected processor does not support ARM mode `smc #0'
> /tmp/ccUyhMOY.s:373: Error: selected processor does not support ARM mode `smc #0'
> make[4]: *** [drivers/firmware/qcom_scm-32.o] Error 1
>
> This changes the Makefile so we pass the ARMv7 architecture level both
> for the check and for the actual compilation of the scm driver.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
Thanks for fixing this. I'll pull it in.
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-13 19:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-12 14:56 [PATCH] firmware: qcom-scm: build for correct architecture level Arnd Bergmann
2015-10-13 19:49 ` Andy Gross
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).