From: sylvain.rochet@finsecur.com (Sylvain Rochet)
To: linux-arm-kernel@lists.infradead.org
Subject: Atmel sama5d3 boot regression, today's linux-next
Date: Thu, 15 Oct 2015 15:30:16 +0200 [thread overview]
Message-ID: <20151015133015.GA28863@gradator.net> (raw)
Hi,
Atmel SAMA5D31 boards no longer boot on today's linux-next. Bisected to:
commit 7d24068e144adc03b805806645d732cf79488717
Author: Wonhong Kwon <wonhongkwon@gmail.com>
Date: Tue Oct 6 10:10:20 2015 +0900
PM / hibernate: Move pm_init/pm_disk_init to late_initcall_sync
pm_init is being invoked by core_initcall and hibernate_image_size_init
calculates preferred image size (image_size) based on total pages
(totalram_pages). This totalram_pages can be modified during various
initcall-s phase and this can cause miscalculated image_size.
For example, when CMA is being used, init_cma_reserved_pageblock tries
to change the totalram_pages and this job is done during core_initcall.
In order words, the totalram_pages doesn't take CMA reserved pages into
account when image_size is calculated and it can be too small.
Move pm_init and pm_disk_init to late_initcall_sync so that it happens
after all other initcall-s change the totalram_pages.
Reported-by: Sangseok Lee <sangseok.lee@lge.com>
Signed-off-by: Wonhong Kwon <wonhong.kwon@lge.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reverting it fixes the issue.
Sylvain
next reply other threads:[~2015-10-15 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-15 13:30 Sylvain Rochet [this message]
2015-10-15 14:14 ` Atmel sama5d3 boot regression, today's linux-next Alexandre Belloni
2015-10-15 15:20 ` Sylvain Rochet
2015-10-15 21:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151015133015.GA28863@gradator.net \
--to=sylvain.rochet@finsecur.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).