linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: gregkh@linuxfoundation.org (Greg Kroah-Hartman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] stm: add configfs dependency
Date: Fri, 16 Oct 2015 23:24:41 -0700	[thread overview]
Message-ID: <20151017062441.GA26793@kroah.com> (raw)
In-Reply-To: <5578991.YxAbTTycJA@wuerfel>

On Sat, Oct 17, 2015 at 12:35:19AM +0200, Arnd Bergmann wrote:
> There are three new stm modules, all of which use configfs for configuration.
> If configfs is not part of the kernel, or is a loadable module while
> the stm driver is builtin, we get a link error like:
> 
> drivers/built-in.o: In function `stp_policy_node_drop':
> drivers/hwtracing/stm/policy.c:232: undefined reference to `config_item_put'
> drivers/built-in.o: In function `stp_policies_make':
> drivers/hwtracing/stm/policy.c:352: undefined reference to `config_group_init_type_name'
> drivers/built-in.o: In function `stp_policy_node_make':
> drivers/hwtracing/stm/policy.c:215: undefined reference to `config_group_init_type_name'
> 
> This adds explicit Kconfig dependencies to ensure configfs is present.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> The patches are currently in Greg's char-misc tree, we should have
> this one in the same branch.
> 
> diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
> index 5a59a28cc3da..6df294fff1eb 100644
> --- a/drivers/hwtracing/stm/Kconfig
> +++ b/drivers/hwtracing/stm/Kconfig
> @@ -1,5 +1,6 @@
>  config STM
>  	tristate "System Trace Module devices"
> +	depends on CONFIGFS_FS

It's better to do a select here, like other drivers do, I have a patch
in my queue to do that, I'll queue it up now.

thanks,

greg k-h

      reply	other threads:[~2015-10-17  6:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-16 22:35 [PATCH] stm: add configfs dependency Arnd Bergmann
2015-10-17  6:24 ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151017062441.GA26793@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).