linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: s.hauer@pengutronix.de (Sascha Hauer)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: imx6: rework getting clocks and regulators
Date: Tue, 20 Oct 2015 15:17:23 +0200	[thread overview]
Message-ID: <20151020131723.GT14476@pengutronix.de> (raw)
In-Reply-To: <CAFSsGVtHaDkXDmnV4-X5z-2y48GM_erSWAYK-6bxR3wv4wHybg@mail.gmail.com>

On Tue, Oct 20, 2015 at 02:56:51PM +0200, Heiner Kallweit wrote:
> On Tue, Oct 20, 2015 at 2:47 PM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > On Tue, Oct 20, 2015 at 02:26:58PM +0200, Lucas Stach wrote:
> >> Am Dienstag, den 20.10.2015, 13:56 +0200 schrieb Sascha Hauer:
> >> > Use devm_* functions for getting clocks and regulators. This simplfifies
> >> > the error path. Also return the error from the failing call instead of
> >> > collating all regulator and clock errors to -ENOENT. With this the
> >> > driver can properly handle -EPROBE_DEFER. Handling deferred probing
> >> > becomes necessary once the SoC internal regulators get supplies. While
> >> > the SoC internal regulators are registered early in architecture code,
> >> > the supplies may be regular I2C devices which may be probed after the
> >> > cpufreq driver.
> >> >
> >> > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> >>
> >> NACK
> >>
> >> This has come up several times before, maybe we should get a comment in
> >> the code.
> >
> > Indeed, yes. This would help not wasting developing time.
> >
> > Anyway, the driver needs to handle -EPROBE_DEFER properly, if not with
> > devm_ then without it.
> >
> About two days ago I sent two patches fixing this. Meanwhile Viresh
> accepted them
> so they should show up in the next kernel very soon.

Thanks for the hint, just found the patches in the archives.
Unfortunately your patches do not work properly, but I'll reply to your
patch.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2015-10-20 13:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20 11:56 [PATCH] cpufreq: imx6: rework getting clocks and regulators Sascha Hauer
2015-10-20 12:26 ` Lucas Stach
2015-10-20 12:47   ` Sascha Hauer
2015-10-20 12:56     ` Heiner Kallweit
2015-10-20 13:17       ` Sascha Hauer [this message]
2015-10-20 14:26         ` Heiner Kallweit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151020131723.GT14476@pengutronix.de \
    --to=s.hauer@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).