From mboxrd@z Thu Jan 1 00:00:00 1970 From: rostedt@goodmis.org (Steven Rostedt) Date: Wed, 21 Oct 2015 11:52:43 -0400 Subject: [PATCH RFC] arm64/ftrace: Define a new arm64 trace clock source based on cntpct_el0 register. In-Reply-To: References: <1445170639-13943-1-git-send-email-amittomer25@gmail.com> <20151021094404.0e3114f9@gandalf.local.home> Message-ID: <20151021115243.0d6d603f@gandalf.local.home> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 21 Oct 2015 21:07:04 +0530 Amit Tomer wrote: > Thank you for looking into it and providing your comments. > > > >> + [local] global counter x86-tsc arm64-pct > > > > You don't need to update this line. You can't have both x86-tsc and > > arm64-pct at the same time. > > Ok, I understand. But is there a nice way to put it, something like > x86-tsc/arm64-pct/... ? No, it's just an example. No need to update it. > > > Why is this a define and not a static inline? > > There is no specific reason to it . I would change it to static inline. Please do. static inline is preferred over defines. We only use defines when a static inline wont work for the needed operation. -- Steve