From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v6 3/3] arm: fix a migrating irq bug when hotplug cpu
Date: Wed, 21 Oct 2015 21:29:08 +0100 [thread overview]
Message-ID: <20151021202907.GN32532@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAMuHMdWyvaecQHOzFnxVZus_Pfkxjw1XfkGdcLK=D2ThaoJMzA@mail.gmail.com>
On Wed, Oct 21, 2015 at 01:47:49PM +0200, Geert Uytterhoeven wrote:
> On Thu, Sep 24, 2015 at 11:32 AM, Yang Yingliang
> <yangyingliang@huawei.com> wrote:
> > When cpu is disabled, all irqs will be migratged to another cpu.
> > In some cases, a new affinity is different, the old affinity need
> > to be updated and if irq_set_affinity's return value is IRQ_SET_MASK_OK_DONE,
> > the old affinity can not be updated. Fix it by using irq_do_set_affinity.
> >
> > And migrating interrupts is a core code matter, so use the generic
> > function irq_migrate_all_off_this_cpu() to migrate interrupts in
> > kernel/irq/migration.c.
> >
> > Cc: Jiang Liu <jiang.liu@linux.intel.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Marc Zyngier <marc.zyngier@arm.com>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > Cc: Will Deacon <will.deacon@arm.com>
> > Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>
> > Cc: Hanjun Guo <hanjun.guo@linaro.org>
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> > ---
> > arch/arm/Kconfig | 1 +
> > arch/arm/include/asm/irq.h | 1 -
> > arch/arm/kernel/irq.c | 62 ----------------------------------------------
> > arch/arm/kernel/smp.c | 2 +-
> > 4 files changed, 2 insertions(+), 64 deletions(-)
> >
> > diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> > index 72ad724..bffba78 100644
> > --- a/arch/arm/Kconfig
> > +++ b/arch/arm/Kconfig
> > @@ -1492,6 +1492,7 @@ config NR_CPUS
> > config HOTPLUG_CPU
> > bool "Support for hot-pluggable CPUs"
> > depends on SMP
> > + select GENERIC_IRQ_MIGRATION
>
> This causes the following warnings during s2ram on r8a7791/koelsch
> (dual-core CA15):
Thanks for the report. I'll see what tonight's boot run says for my
platforms. Hopefully, the author of these changes can help debug
this.
--
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-10-21 20:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 9:32 [RFC PATCH v6 0/3] arm/arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-24 9:32 ` [RFC PATCH v6 1/3] genirq: introduce CONFIG_GENERIC_IRQ_MIGRATION and kernel/irq/cpuhotplug.c Yang Yingliang
[not found] ` <tip-f1e0bb0ad473a32d1b7e6d285ae9f7e47710bb5e@git.kernel.org>
2015-10-01 14:24 ` [tip:irq/core] genirq: Introduce generic irq migration for cpu hotunplug Thomas Gleixner
2015-10-01 14:47 ` Catalin Marinas
2015-09-24 9:32 ` [RFC PATCH v6 2/3] arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-10-09 16:55 ` Catalin Marinas
2015-09-24 9:32 ` [RFC PATCH v6 3/3] arm: " Yang Yingliang
2015-10-13 19:28 ` Russell King - ARM Linux
2015-10-21 11:47 ` Geert Uytterhoeven
2015-10-21 20:29 ` Russell King - ARM Linux [this message]
2015-10-22 9:26 ` Russell King - ARM Linux
2015-10-22 9:46 ` Geert Uytterhoeven
2015-10-22 10:56 ` Yang Yingliang
2015-10-22 11:13 ` Russell King - ARM Linux
2015-10-22 12:43 ` Thomas Gleixner
2015-10-22 16:34 ` Catalin Marinas
2015-12-15 6:59 ` Yang Yingliang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151021202907.GN32532@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).