From mboxrd@z Thu Jan 1 00:00:00 1970 From: sboyd@codeaurora.org (Stephen Boyd) Date: Wed, 21 Oct 2015 16:17:12 -0700 Subject: [PATCH 5/5] clk: scpi: add missing of_node_put In-Reply-To: <1445460100-26727-6-git-send-email-Julia.Lawall@lip6.fr> References: <1445460100-26727-1-git-send-email-Julia.Lawall@lip6.fr> <1445460100-26727-6-git-send-email-Julia.Lawall@lip6.fr> Message-ID: <20151021231712.GL19782@codeaurora.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/21, Julia Lawall wrote: > for_each_available_child_of_node performs an of_node_get on each iteration, > so a break out of the loop requires an of_node_put. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // > @@ > expression root,e; > local idexpression child; > @@ > > for_each_available_child_of_node(root, child) { > ... when != of_node_put(child) > when != e = child > ( > return child; > | > + of_node_put(child); > ? return ...; > ) > ... > } > // > > Signed-off-by: Julia Lawall > > --- Acked-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project