linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matt@codeblueprint.co.uk (Matt Fleming)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64/efi: move arm64 specific stub C code to libstub
Date: Tue, 27 Oct 2015 21:07:35 +0000	[thread overview]
Message-ID: <20151027210735.GA8973@codeblueprint.co.uk> (raw)
In-Reply-To: <CAKv+Gu-2-=b-+X8xRpVFO5oFE2_0Eho2-H6VWYWWqonOdaKL5w@mail.gmail.com>

On Tue, 27 Oct, at 11:10:43AM, Ard Biesheuvel wrote:
> On 27 October 2015 at 06:11, Matt Fleming <matt@codeblueprint.co.uk> wrote:
> > On Fri, 23 Oct, at 04:48:14PM, Ard Biesheuvel wrote:
> >> Now that we added special handling to the C files in libstub, move
> >> the one remaining arm64 specific EFI stub C file to libstub as
> >> well, so that it gets the same treatment. This should prevent future
> >> changes from resulting in binaries that may execute incorrectly in
> >> UEFI context.
> >
> > Sorry, I'm coming at this cache-cold: What special handling was added
> > to libstub that you want to make use of here?
> >
> 
> This is about the libstub patches that you reviewed ~2 weeks ago and
> that have been queued in Catalin's arm64 tree for 4.4
> 
> >> With efi-entry.S the only remaining EFI stub source file under
> >> arch/arm64, we can also simplify the Makefile logic somewhat.
> >>
> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> ---
> >>
> >> I would like to suggest that this be taken on top of the stuff that is
> >> queued for 4.4 at the moment (if it is not too late already).
> >
> > That's upto the tip folks (Cc'd). Ingo, would you consider applying
> > a minimal build cleanup patch like this for v4.4?
> >
> 
> Actually, the suggestion was aimed at Catalin, who has all the libstub
> and KASAN patches queued that this patch depends on.
> Apologies for the confusion.

Fair enough. In that case (for the drivers/firmware bits),

Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

  reply	other threads:[~2015-10-27 21:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-23 14:48 [PATCH] arm64/efi: move arm64 specific stub C code to libstub Ard Biesheuvel
2015-10-26 21:11 ` Matt Fleming
2015-10-27  2:10   ` Ard Biesheuvel
2015-10-27 21:07     ` Matt Fleming [this message]
2015-10-29 18:39 ` Catalin Marinas
2015-10-30 11:57   ` Ard Biesheuvel
2015-10-30 15:43     ` Catalin Marinas
2015-10-30 15:40 ` Jeremy Linton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151027210735.GA8973@codeblueprint.co.uk \
    --to=matt@codeblueprint.co.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).