linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM64: Enable multi-core scheduler support by default
Date: Fri, 30 Oct 2015 15:35:43 +0000	[thread overview]
Message-ID: <20151030153543.GY8899@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <5633628C.1010200@arm.com>

On Fri, Oct 30, 2015 at 12:29:00PM +0000, Dietmar Eggemann wrote:
> On 10/29/2015 05:19 PM, Catalin Marinas wrote:
> >On Mon, Oct 19, 2015 at 05:55:49PM +0100, Dietmar Eggemann wrote:
> >>Make sure that the task scheduler domain hierarchy is set-up correctly
> >>on systems with single or multi-cluster topology.
> >>
> >>Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
> >>---
> >>  arch/arm64/configs/defconfig | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >>diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> >>index 34d71dd86781..dc70d715bc38 100644
> >>--- a/arch/arm64/configs/defconfig
> >>+++ b/arch/arm64/configs/defconfig
> >>@@ -51,6 +51,7 @@ CONFIG_PCI=y
> >>  CONFIG_PCI_MSI=y
> >>  CONFIG_PCI_XGENE=y
> >>  CONFIG_SMP=y
> >>+CONFIG_SCHED_MC=y
> >>  CONFIG_PREEMPT=y
> >>  CONFIG_KSM=y
> >>  CONFIG_TRANSPARENT_HUGEPAGE=y
> >
> >Question: does enabling this option have any (positive) effect on the
> >vanilla kernel or it requires additional patches like EAS?
> 
> It improves the task scheduler decisions on multi-cluster systems. You have
> to iterate over all cpu's less frequently when gathering the sched group
> statistics e.g. during CFS load-balancing.
> 
> You essentially replace a flat (all cpus) with an hierarchical approach
> (lowest level: sched group eq. cpu, next level: sched group eq. cluster) and
> do CFS load balancing frequently between two cpu's of the same cluster
> (lowest level) and less frequently between two cpus from different cluster.
> 
> Not sure that I would see an effect on the performance score on a JUNO board
> when running hackbench. Could give it a try ... Probably easier to spot on a
> machine with >32 logical cpus.

I did some tests on Juno last week with and without this option and I
haven't noticed any difference.

Anyway, thanks for the explanation. Patch applied.

-- 
Catalin

      reply	other threads:[~2015-10-30 15:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-19 16:55 [PATCH] ARM64: Enable multi-core scheduler support by default Dietmar Eggemann
2015-10-28 14:01 ` Punit Agrawal
2015-10-29 17:19 ` Catalin Marinas
2015-10-30 12:29   ` Dietmar Eggemann
2015-10-30 15:35     ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151030153543.GY8899@e104818-lin.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).