From: alexandre.belloni@free-electrons.com (Alexandre Belloni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK
Date: Mon, 2 Nov 2015 00:45:20 +0100 [thread overview]
Message-ID: <20151101234520.GH22331@piout.net> (raw)
In-Reply-To: <1446420425-5491-1-git-send-email-marex@denx.de>
Hi Marek,
On 02/11/2015 at 00:27:05 +0100, Marek Vasut wrote :
> + clocks {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
You probably don't need those three properties
> + main_clock: clock at 0 {
> + compatible = "atmel,osc", "fixed-clock";
> + clock-frequency = <12000000>;
> + };
> +
likewise, if you don't need to boot on older kernels, I'd suggest
removing clock at 0.
> +/ {
> + model = "DENX MA5D4EVK";
> + compatible = "denx,ma5d4evk", "atmel,sama5d4", "atmel,sama5";
> +
> + chosen {
> + bootargs = "ignore_loglevel earlyprintk";
I think you don't really want to enforce those options, especially
earlyprintk as it can lead to a crash if UART_PHYS is not set properly
(for example, I usually boot the same kernel on sama5d3 and sama5d4).
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2015-11-01 23:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-01 23:27 [PATCH] ARM: at91/dt: sama5d4: Add support for DENX MA5D4 SoM and EVK Marek Vasut
2015-11-01 23:45 ` Alexandre Belloni [this message]
2015-11-01 23:56 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151101234520.GH22331@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).